| Message ID | 20171013011954.9975-1-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | docker: Don't allocate tty unless DEBUG=1 | expand |
Fam Zheng <famz@redhat.com> writes: > The existence of tty in the container seems to urge gcc into colorize > the output, but the escape chars will clutter the report once turned > into email replies on patchew. Move -t to debug mode. > > Reported-by: Eric Blake <eblake@redhat.com> > Signed-off-by: Fam Zheng <famz@redhat.com> I certainly improves my Emacs compilation-mode buffer when applied: Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/docker/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > index 6f9ea196a7..ab939f2bec 100644 > --- a/tests/docker/Makefile.include > +++ b/tests/docker/Makefile.include > @@ -134,10 +134,10 @@ docker-run: docker-qemu-src > " COPYING $(EXECUTABLE) to $(IMAGE)")) > $(call quiet-command, \ > $(SRC_PATH)/tests/docker/docker.py run \ > - $(if $(NOUSER),,-u $(shell id -u)) -t \ > + $(if $(NOUSER),,-u $(shell id -u)) \ > --security-opt seccomp=unconfined \ > $(if $V,,--rm) \ > - $(if $(DEBUG),-i,) \ > + $(if $(DEBUG),-ti,) \ > $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \ > -e TARGET_LIST=$(TARGET_LIST) \ > -e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \ -- Alex Bennée
On Fri, 10/13 10:35, Alex Bennée wrote: > > Fam Zheng <famz@redhat.com> writes: > > > The existence of tty in the container seems to urge gcc into colorize > > the output, but the escape chars will clutter the report once turned > > into email replies on patchew. Move -t to debug mode. > > > > Reported-by: Eric Blake <eblake@redhat.com> > > Signed-off-by: Fam Zheng <famz@redhat.com> > > I certainly improves my Emacs compilation-mode buffer when applied: > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Nice, thanks! I'll send a pull request soon. Fam
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 6f9ea196a7..ab939f2bec 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -134,10 +134,10 @@ docker-run: docker-qemu-src " COPYING $(EXECUTABLE) to $(IMAGE)")) $(call quiet-command, \ $(SRC_PATH)/tests/docker/docker.py run \ - $(if $(NOUSER),,-u $(shell id -u)) -t \ + $(if $(NOUSER),,-u $(shell id -u)) \ --security-opt seccomp=unconfined \ $(if $V,,--rm) \ - $(if $(DEBUG),-i,) \ + $(if $(DEBUG),-ti,) \ $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \ -e TARGET_LIST=$(TARGET_LIST) \ -e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \
The existence of tty in the container seems to urge gcc into colorize the output, but the escape chars will clutter the report once turned into email replies on patchew. Move -t to debug mode. Reported-by: Eric Blake <eblake@redhat.com> Signed-off-by: Fam Zheng <famz@redhat.com> --- tests/docker/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)