| Message ID | 1507548926-9555-4-git-send-email-chaotian.jing@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | mmc: mediatek: add support of mt2701/mt2712 | expand |
On 10/09/2017 01:35 PM, Chaotian Jing wrote: > the driver has updated to have an explicit compatible, so update > binding file according to the driver change. > > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 3e0a97c..2bb585b 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -8,8 +8,8 @@ and the properties used by the msdc driver. > > Required properties: > - compatible: value should be either of the following. > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173 > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 You can merge this with patch 1. > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > - reg: physical base address of the controller and length > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote: > > On 10/09/2017 01:35 PM, Chaotian Jing wrote: > > the driver has updated to have an explicit compatible, so update > > binding file according to the driver change. > > > > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com> > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index 3e0a97c..2bb585b 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -8,8 +8,8 @@ and the properties used by the msdc driver. > > > > Required properties: > > - compatible: value should be either of the following. > > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173 > > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > > You can merge this with patch 1. OK, will merge it in next patch. > > > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > > - reg: physical base address of the controller and length > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10 October 2017 at 03:37, Chaotian Jing <chaotian.jing@mediatek.com> wrote: > On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote: >> >> On 10/09/2017 01:35 PM, Chaotian Jing wrote: >> > the driver has updated to have an explicit compatible, so update >> > binding file according to the driver change. >> > >> > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com> >> > --- >> > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt >> > index 3e0a97c..2bb585b 100644 >> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt >> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt >> > @@ -8,8 +8,8 @@ and the properties used by the msdc driver. >> > >> > Required properties: >> > - compatible: value should be either of the following. >> > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 >> > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173 >> > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 >> > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 >> >> You can merge this with patch 1. > > OK, will merge it in next patch. No, please don't! I would like DT documentation changes to be posted in separate patches. Moreover, those should be before driver changes, when you order the changes in your series. In this way, the bindings can be reviewed and acked separately, which makes it more convenient. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/10/2017 09:19 AM, Ulf Hansson wrote: > On 10 October 2017 at 03:37, Chaotian Jing <chaotian.jing@mediatek.com> wrote: >> On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote: >>> >>> On 10/09/2017 01:35 PM, Chaotian Jing wrote: >>>> the driver has updated to have an explicit compatible, so update >>>> binding file according to the driver change. >>>> >>>> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com> >>>> --- >>>> Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt >>>> index 3e0a97c..2bb585b 100644 >>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt >>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt >>>> @@ -8,8 +8,8 @@ and the properties used by the msdc driver. >>>> >>>> Required properties: >>>> - compatible: value should be either of the following. >>>> - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 >>>> - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173 >>>> + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 >>>> + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 >>> >>> You can merge this with patch 1. >> >> OK, will merge it in next patch. > > No, please don't! > > I would like DT documentation changes to be posted in separate > patches. Moreover, those should be before driver changes, when you > order the changes in your series. > > In this way, the bindings can be reviewed and acked separately, which > makes it more convenient. > Sounds reasonable, sorry for the confusion. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Oct 10, 2017 at 09:19:14AM +0200, Ulf Hansson wrote: > On 10 October 2017 at 03:37, Chaotian Jing <chaotian.jing@mediatek.com> wrote: > > On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote: > >> > >> On 10/09/2017 01:35 PM, Chaotian Jing wrote: > >> > the driver has updated to have an explicit compatible, so update > >> > binding file according to the driver change. > >> > > >> > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com> > >> > --- > >> > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++-- > >> > 1 file changed, 2 insertions(+), 2 deletions(-) > >> > > >> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > >> > index 3e0a97c..2bb585b 100644 > >> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > >> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > >> > @@ -8,8 +8,8 @@ and the properties used by the msdc driver. > >> > > >> > Required properties: > >> > - compatible: value should be either of the following. > >> > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > >> > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173 > >> > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > >> > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > >> > >> You can merge this with patch 1. > > > > OK, will merge it in next patch. > > No, please don't! > > I would like DT documentation changes to be posted in separate > patches. Moreover, those should be before driver changes, when you > order the changes in your series. > > In this way, the bindings can be reviewed and acked separately, which > makes it more convenient. Yes. Also, it is step 2 in Documentation/devicetree/bindings/submitting-patches.txt. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Oct 09, 2017 at 07:35:16PM +0800, Chaotian Jing wrote: > the driver has updated to have an explicit compatible, so update > binding file according to the driver change. Normally, that's not a reason for a binding change. An old kernel without the driver change is still valid. > > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 3e0a97c..2bb585b 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -8,8 +8,8 @@ and the properties used by the msdc driver. > > Required properties: > - compatible: value should be either of the following. > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 Except this one didn't really make sense. "mediatek,mt8135-mmc" should be the most specific compatible on a MT8135. > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173 Why is the version in MT8173 no longer compatible with a driver that supports "mediatek,mt8135-mmc"? Your commit msg needs to answer that question. > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > - reg: physical base address of the controller and length > -- > 1.8.1.1.dirty > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2017-10-13 at 15:14 -0500, Rob Herring wrote: > On Mon, Oct 09, 2017 at 07:35:16PM +0800, Chaotian Jing wrote: > > the driver has updated to have an explicit compatible, so update > > binding file according to the driver change. > > Normally, that's not a reason for a binding change. An old kernel > without the driver change is still valid. > > > > > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com> > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index 3e0a97c..2bb585b 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -8,8 +8,8 @@ and the properties used by the msdc driver. > > > > Required properties: > > - compatible: value should be either of the following. > > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > > Except this one didn't really make sense. "mediatek,mt8135-mmc" should > be the most specific compatible on a MT8135. > > > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173 > > Why is the version in MT8173 no longer compatible with a driver that > supports "mediatek,mt8135-mmc"? Your commit msg needs to answer that > question. OK, will answer it in commit msg at next version. > > > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > > - reg: physical base address of the controller and length > > -- > > 1.8.1.1.dirty > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt index 3e0a97c..2bb585b 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt @@ -8,8 +8,8 @@ and the properties used by the msdc driver. Required properties: - compatible: value should be either of the following. - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173 + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 - reg: physical base address of the controller and length
the driver has updated to have an explicit compatible, so update binding file according to the driver change. Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com> --- Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)