| Message ID | 1291906126-475-1-git-send-email-tklauser@distanz.ch |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Dec 9, 2010 at 09:48, Tobias Klauser wrote: > IS_ERR() already implies unlikely(), so it can be omitted here. sounds like something that checkpatch.pl could look for ... > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Acked-by: Mike Frysinger <vapier@gentoo.org> -mike
On 2010-12-09 at 17:14:20 +0100, Mike Frysinger <vapier.adi@gmail.com> wrote: > On Thu, Dec 9, 2010 at 09:48, Tobias Klauser wrote: > > IS_ERR() already implies unlikely(), so it can be omitted here. > > sounds like something that checkpatch.pl could look for ... I'll send a patch, thanks for the suggestion. Cheers Tobias
diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c index b4b6087..4ba3e33 100644 --- a/drivers/rtc/rtc-bfin.c +++ b/drivers/rtc/rtc-bfin.c @@ -383,7 +383,7 @@ static int __devinit bfin_rtc_probe(struct platform_device *pdev) /* Register our RTC with the RTC framework */ rtc->rtc_dev = rtc_device_register(pdev->name, dev, &bfin_rtc_ops, THIS_MODULE); - if (unlikely(IS_ERR(rtc->rtc_dev))) { + if (IS_ERR(rtc->rtc_dev)) { ret = PTR_ERR(rtc->rtc_dev); goto err; }
IS_ERR() already implies unlikely(), so it can be omitted here. Signed-off-by: Tobias Klauser <tklauser@distanz.ch> --- drivers/rtc/rtc-bfin.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)