| Message ID | 20170915230744.22942-1-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | MAINTAINERS: Add Python scripts | expand |
On 09/15/2017 07:07 PM, Eduardo Habkost wrote: > Cleber and I are volunteering to review and queue patches for the > Python scripts and modules in scripts/. > > I'm setting "M: Odd fixes" because not all scripts are actively > maintained. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > Even before this patch is merged, I plan to send a pull request > including some patches for the Python code soon. > --- > MAINTAINERS | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2c333aba21..2c3b8ecde7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1390,6 +1390,13 @@ S: Maintained > F: include/sysemu/cryptodev*.h > F: backends/cryptodev*.c > > +Python scripts > +M: Eduardo Habkost <ehabkost@redhat.com> > +M: Cleber Rosa <crosa@redhat.com> > +S: Odd fixes > +F: scripts/qmp/* > +F: scripts/*.py > + > QAPI > M: Markus Armbruster <armbru@redhat.com> > M: Michael Roth <mdroth@linux.vnet.ibm.com> > I rather like the thought of having dedicated Python maintainers who can review python code with an eye for what is idiomatic. I am fairly certain the python I write is functional, but I'm rarely sure it's what a python programmer would do. I suppose you are intentionally omitting any python that exists as part of the test infrastructure, however? John
On Fri, Sep 15, 2017 at 08:17:18PM -0400, John Snow wrote: > > > On 09/15/2017 07:07 PM, Eduardo Habkost wrote: > > Cleber and I are volunteering to review and queue patches for the > > Python scripts and modules in scripts/. > > > > I'm setting "M: Odd fixes" because not all scripts are actively > > maintained. > > > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > --- > > Even before this patch is merged, I plan to send a pull request > > including some patches for the Python code soon. > > --- > > MAINTAINERS | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 2c333aba21..2c3b8ecde7 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1390,6 +1390,13 @@ S: Maintained > > F: include/sysemu/cryptodev*.h > > F: backends/cryptodev*.c > > > > +Python scripts > > +M: Eduardo Habkost <ehabkost@redhat.com> > > +M: Cleber Rosa <crosa@redhat.com> > > +S: Odd fixes > > +F: scripts/qmp/* > > +F: scripts/*.py > > + > > QAPI > > M: Markus Armbruster <armbru@redhat.com> > > M: Michael Roth <mdroth@linux.vnet.ibm.com> > > > > I rather like the thought of having dedicated Python maintainers who can > review python code with an eye for what is idiomatic. I am fairly > certain the python I write is functional, but I'm rarely sure it's what > a python programmer would do. > > I suppose you are intentionally omitting any python that exists as part > of the test infrastructure, however? Initially, yes. I was trying to include only the stuff we were actively maintaining. But later I decided to use "S: Odd fixes" instead of "S: Maintained", so I guess it won't hurt to include this: --- diff --git a/MAINTAINERS b/MAINTAINERS index 2c3b8ecde7..876ac0df99 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1396,6 +1396,8 @@ M: Cleber Rosa <crosa@redhat.com> S: Odd fixes F: scripts/qmp/* F: scripts/*.py +F: tests/*.py +K: #!.*python QAPI M: Markus Armbruster <armbru@redhat.com>
On Fri, Sep 15, 2017 at 09:38:32PM -0300, Eduardo Habkost wrote: > On Fri, Sep 15, 2017 at 08:17:18PM -0400, John Snow wrote: > > > > > > On 09/15/2017 07:07 PM, Eduardo Habkost wrote: > > > Cleber and I are volunteering to review and queue patches for the > > > Python scripts and modules in scripts/. > > > > > > I'm setting "M: Odd fixes" because not all scripts are actively > > > maintained. > > > > > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > > --- > > > Even before this patch is merged, I plan to send a pull request > > > including some patches for the Python code soon. > > > --- > > > MAINTAINERS | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 2c333aba21..2c3b8ecde7 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -1390,6 +1390,13 @@ S: Maintained > > > F: include/sysemu/cryptodev*.h > > > F: backends/cryptodev*.c > > > > > > +Python scripts > > > +M: Eduardo Habkost <ehabkost@redhat.com> > > > +M: Cleber Rosa <crosa@redhat.com> > > > +S: Odd fixes > > > +F: scripts/qmp/* > > > +F: scripts/*.py > > > + > > > QAPI > > > M: Markus Armbruster <armbru@redhat.com> > > > M: Michael Roth <mdroth@linux.vnet.ibm.com> > > > > > > > I rather like the thought of having dedicated Python maintainers who can > > review python code with an eye for what is idiomatic. I am fairly > > certain the python I write is functional, but I'm rarely sure it's what > > a python programmer would do. > > > > I suppose you are intentionally omitting any python that exists as part > > of the test infrastructure, however? > > Initially, yes. I was trying to include only the stuff we were > actively maintaining. But later I decided to use "S: Odd fixes" > instead of "S: Maintained", so I guess it won't hurt to include > this: > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/MAINTAINERS b/MAINTAINERS index 2c333aba21..2c3b8ecde7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1390,6 +1390,13 @@ S: Maintained F: include/sysemu/cryptodev*.h F: backends/cryptodev*.c +Python scripts +M: Eduardo Habkost <ehabkost@redhat.com> +M: Cleber Rosa <crosa@redhat.com> +S: Odd fixes +F: scripts/qmp/* +F: scripts/*.py + QAPI M: Markus Armbruster <armbru@redhat.com> M: Michael Roth <mdroth@linux.vnet.ibm.com>
Cleber and I are volunteering to review and queue patches for the Python scripts and modules in scripts/. I'm setting "M: Odd fixes" because not all scripts are actively maintained. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Even before this patch is merged, I plan to send a pull request including some patches for the Python code soon. --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)