| Message ID | 20170915020004.24272-1-alexandre.belloni@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] RTC: rv3029: fix vendor string | expand |
On 15/09/2017 at 04:00, Alexandre Belloni wrote: > The rv3029 compatible is missing its vendor string, add it. > Also fix the node name to be a proper generic name. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > arch/arm/boot/dts/usb_a9g20_common.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/usb_a9g20_common.dtsi b/arch/arm/boot/dts/usb_a9g20_common.dtsi > index 088c2c3685ab..81c3fe0465d9 100644 > --- a/arch/arm/boot/dts/usb_a9g20_common.dtsi > +++ b/arch/arm/boot/dts/usb_a9g20_common.dtsi > @@ -20,8 +20,8 @@ > }; > > i2c-gpio-0 { > - rv3029c2@56 { > - compatible = "rv3029c2"; > + rtc@56 { > + compatible = "microcrystal,rv3029"; > reg = <0x56>; > }; > }; >
On Fri, 15 Sep 2017 04:00:04 +0200 Alexandre Belloni alexandre.belloni@free-electrons.com wrote: >The proper compatible for rv3029 is microcrystal,rv3029. > >Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Acked-by: Anatolij Gustschin <agust@denx.de>
On Fri, Sep 15, 2017 at 04:00:02AM +0200, Alexandre Belloni wrote: > The vendor string for Microcrystal is microcrystal. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > --- > Documentation/devicetree/bindings/trivial-devices.txt | 2 +- > drivers/rtc/rtc-rv3029c2.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org>
Hi, On 15/09/2017 at 09:13:26 +0200, Anatolij Gustschin wrote: > On Fri, 15 Sep 2017 04:00:04 +0200 > Alexandre Belloni alexandre.belloni@free-electrons.com wrote: > > >The proper compatible for rv3029 is microcrystal,rv3029. > > > >Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > Acked-by: Anatolij Gustschin <agust@denx.de> If that is fine for you, I would prefer that goes through your tree as I'm not usually taking DT patches through the RTC tree. there is no dependency as the i2c subsystem will already match the new compatible with the i2c device_id.
diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt index af284fbd4d23..aae37352c574 100644 --- a/Documentation/devicetree/bindings/trivial-devices.txt +++ b/Documentation/devicetree/bindings/trivial-devices.txt @@ -72,7 +72,6 @@ isil,isl29030 Intersil ISL29030 Ambient Light and Proximity Sensor maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs maxim,max6625 9-Bit/12-Bit Temperature Sensors with I²C-Compatible Serial Interface -mc,rv3029c2 Real Time Clock Module with I2C-Bus mcube,mc3230 mCube 3-axis 8-bit digital accelerometer memsic,mxc6225 MEMSIC 2-axis 8-bit digital accelerometer microchip,mcp4531-502 Microchip 7-bit Single I2C Digital Potentiometer (5k) @@ -141,6 +140,7 @@ microchip,mcp4662-503 Microchip 8-bit Dual I2C Digital Potentiometer with NV Mem microchip,mcp4662-104 Microchip 8-bit Dual I2C Digital Potentiometer with NV Memory (100k) microchip,tc654 PWM Fan Speed Controller With Fan Fault Detection microchip,tc655 PWM Fan Speed Controller With Fan Fault Detection +microcrystal,rv3029 Real Time Clock Module with I2C-Bus miramems,da226 MiraMEMS DA226 2-axis 14-bit digital accelerometer miramems,da280 MiraMEMS DA280 3-axis 14-bit digital accelerometer miramems,da311 MiraMEMS DA311 3-axis 12-bit digital accelerometer diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c index aa09771de04f..cfe3aece51d1 100644 --- a/drivers/rtc/rtc-rv3029c2.c +++ b/drivers/rtc/rtc-rv3029c2.c @@ -876,6 +876,8 @@ static const struct i2c_device_id rv3029_id[] = { MODULE_DEVICE_TABLE(i2c, rv3029_id); static const struct of_device_id rv3029_of_match[] = { + { .compatible = "microcrystal,rv3029" }, + /* Backward compatibility only, do not use compatibles below: */ { .compatible = "rv3029" }, { .compatible = "rv3029c2" }, { .compatible = "mc,rv3029c2" },
The vendor string for Microcrystal is microcrystal. Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> --- Documentation/devicetree/bindings/trivial-devices.txt | 2 +- drivers/rtc/rtc-rv3029c2.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)