Message ID | 1504910713-7094-8-git-send-email-linuxram@us.ibm.com (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show |
Series | powerpc: Free up RPAGE_RSV bits | expand |
On Fri, 8 Sep 2017 15:44:47 -0700 Ram Pai <linuxram@us.ibm.com> wrote: > The H_PAGE_F_SECOND,H_PAGE_F_GIX are not in the 64K main-PTE. > capture these changes in the dump pte report. > > Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > Signed-off-by: Ram Pai <linuxram@us.ibm.com> > --- So we lose slot and secondary information for 64K PTE's with this change? Balbir
On Thu, Sep 14, 2017 at 01:22:27PM +1000, Balbir Singh wrote: > On Fri, 8 Sep 2017 15:44:47 -0700 > Ram Pai <linuxram@us.ibm.com> wrote: > > > The H_PAGE_F_SECOND,H_PAGE_F_GIX are not in the 64K main-PTE. > > capture these changes in the dump pte report. > > > > Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > > Signed-off-by: Ram Pai <linuxram@us.ibm.com> > > --- > > So we lose slot and secondary information for 64K PTE's with > this change? yes. It was anyway not there for 4k-backed-64k ptes. Now it wont be there for any 64k ptes. RP
diff --git a/arch/powerpc/mm/dump_linuxpagetables.c b/arch/powerpc/mm/dump_linuxpagetables.c index c9282d2..0323dc4 100644 --- a/arch/powerpc/mm/dump_linuxpagetables.c +++ b/arch/powerpc/mm/dump_linuxpagetables.c @@ -213,7 +213,7 @@ struct flag_info { .val = H_PAGE_4K_PFN, .set = "4K_pfn", }, { -#endif +#else /* CONFIG_PPC_64K_PAGES */ .mask = H_PAGE_F_GIX, .val = H_PAGE_F_GIX, .set = "f_gix", @@ -224,6 +224,7 @@ struct flag_info { .val = H_PAGE_F_SECOND, .set = "f_second", }, { +#endif /* CONFIG_PPC_64K_PAGES */ #endif .mask = _PAGE_SPECIAL, .val = _PAGE_SPECIAL,