| Message ID | 20170803081411.22389-2-wens@csie.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thursday 03 August 2017 01:44 PM, Chen-Yu Tsai wrote: > The Allwinner H3 SoC has 4 USB PHYs, so it needs four sets of pmu > regions, clocks, resets, and optional vbus properties. These were > not described when the H3 compatible string was added. > > Fixes: 626a630e003c ("phy-sun4i-usb: Add support for the host usb-phys > found on the H3 SoC") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Rob, can you give your Acked-by for this patch? Thanks Kishon > --- > Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt > index 005bc22938ff..893dd01dfe64 100644 > --- a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt > +++ b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt > @@ -17,18 +17,21 @@ Required properties: > * "phy_ctrl" > * "pmu0" for H3, V3s and A64 > * "pmu1" > - * "pmu2" for sun4i, sun6i or sun7i > + * "pmu2" for sun4i, sun6i, sun7i or sun8i-h3 > + * "pmu3" for sun8i-h3 > - #phy-cells : from the generic phy bindings, must be 1 > - clocks : phandle + clock specifier for the phy clocks > - clock-names : > * "usb_phy" for sun4i, sun5i or sun7i > * "usb0_phy", "usb1_phy" and "usb2_phy" for sun6i > * "usb0_phy", "usb1_phy" for sun8i > + * "usb0_phy", "usb1_phy", "usb2_phy" and "usb3_phy" for sun8i-h3 > - resets : a list of phandle + reset specifier pairs > - reset-names : > * "usb0_reset" > * "usb1_reset" > - * "usb2_reset" for sun4i, sun6i or sun7i > + * "usb2_reset" for sun4i, sun6i, sun7i or sun8i-h3 > + * "usb3_reset" for sun8i-h3 > > Optional properties: > - usb0_id_det-gpios : gpio phandle for reading the otg id pin value > @@ -37,6 +40,7 @@ Optional properties: > - usb0_vbus-supply : regulator phandle for controller usb0 vbus > - usb1_vbus-supply : regulator phandle for controller usb1 vbus > - usb2_vbus-supply : regulator phandle for controller usb2 vbus > +- usb3_vbus-supply : regulator phandle for controller usb3 vbus > > Example: > usbphy: phy@0x01c13400 { > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 03, 2017 at 04:14:04PM +0800, Chen-Yu Tsai wrote: > The Allwinner H3 SoC has 4 USB PHYs, so it needs four sets of pmu > regions, clocks, resets, and optional vbus properties. These were > not described when the H3 compatible string was added. > > Fixes: 626a630e003c ("phy-sun4i-usb: Add support for the host usb-phys > found on the H3 SoC") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 11, 2017 at 1:08 AM, Rob Herring <robh@kernel.org> wrote: > On Thu, Aug 03, 2017 at 04:14:04PM +0800, Chen-Yu Tsai wrote: >> The Allwinner H3 SoC has 4 USB PHYs, so it needs four sets of pmu >> regions, clocks, resets, and optional vbus properties. These were >> not described when the H3 compatible string was added. >> >> Fixes: 626a630e003c ("phy-sun4i-usb: Add support for the host usb-phys >> found on the H3 SoC") >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) > > Acked-by: Rob Herring <robh@kernel.org> Kishon, are the dt binding and driver parts of this series OK for 4.14? I'd like to get an answer from you to be able to merge the device tree parts. Thanks ChenYu -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Thursday 17 August 2017 10:35 PM, Chen-Yu Tsai wrote: > On Fri, Aug 11, 2017 at 1:08 AM, Rob Herring <robh@kernel.org> wrote: >> On Thu, Aug 03, 2017 at 04:14:04PM +0800, Chen-Yu Tsai wrote: >>> The Allwinner H3 SoC has 4 USB PHYs, so it needs four sets of pmu >>> regions, clocks, resets, and optional vbus properties. These were >>> not described when the H3 compatible string was added. >>> >>> Fixes: 626a630e003c ("phy-sun4i-usb: Add support for the host usb-phys >>> found on the H3 SoC") >>> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >>> --- >>> Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 8 ++++++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> Acked-by: Rob Herring <robh@kernel.org> > > Kishon, are the dt binding and driver parts of this series OK for > 4.14? I'd like to get an answer from you to be able to merge the > device tree parts. Yes. I merged the phy driver patches to phy tree. I'm not able to merge the dt-bindings patch due to conflicts. Can you resend the dt-binding patch based on linux-phy next or let me know if I'm missing any dependent patch. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 18, 2017 at 6:53 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote: > Hi, > > On Thursday 17 August 2017 10:35 PM, Chen-Yu Tsai wrote: >> On Fri, Aug 11, 2017 at 1:08 AM, Rob Herring <robh@kernel.org> wrote: >>> On Thu, Aug 03, 2017 at 04:14:04PM +0800, Chen-Yu Tsai wrote: >>>> The Allwinner H3 SoC has 4 USB PHYs, so it needs four sets of pmu >>>> regions, clocks, resets, and optional vbus properties. These were >>>> not described when the H3 compatible string was added. >>>> >>>> Fixes: 626a630e003c ("phy-sun4i-usb: Add support for the host usb-phys >>>> found on the H3 SoC") >>>> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >>>> --- >>>> Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 8 ++++++-- >>>> 1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> Acked-by: Rob Herring <robh@kernel.org> >> >> Kishon, are the dt binding and driver parts of this series OK for >> 4.14? I'd like to get an answer from you to be able to merge the >> device tree parts. > > Yes. I merged the phy driver patches to phy tree. I'm not able to merge the > dt-bindings patch due to conflicts. Can you resend the dt-binding patch based > on linux-phy next or let me know if I'm missing any dependent patch. That's weird. I just applied both patches on top of linux-phy/next and there were no conflicts or issues. Note that there are two dt binding patches, patches 1 and 2 in this series. Patch 1 has to be applied before patch 2 Thanks ChenYu -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt index 005bc22938ff..893dd01dfe64 100644 --- a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt +++ b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt @@ -17,18 +17,21 @@ Required properties: * "phy_ctrl" * "pmu0" for H3, V3s and A64 * "pmu1" - * "pmu2" for sun4i, sun6i or sun7i + * "pmu2" for sun4i, sun6i, sun7i or sun8i-h3 + * "pmu3" for sun8i-h3 - #phy-cells : from the generic phy bindings, must be 1 - clocks : phandle + clock specifier for the phy clocks - clock-names : * "usb_phy" for sun4i, sun5i or sun7i * "usb0_phy", "usb1_phy" and "usb2_phy" for sun6i * "usb0_phy", "usb1_phy" for sun8i + * "usb0_phy", "usb1_phy", "usb2_phy" and "usb3_phy" for sun8i-h3 - resets : a list of phandle + reset specifier pairs - reset-names : * "usb0_reset" * "usb1_reset" - * "usb2_reset" for sun4i, sun6i or sun7i + * "usb2_reset" for sun4i, sun6i, sun7i or sun8i-h3 + * "usb3_reset" for sun8i-h3 Optional properties: - usb0_id_det-gpios : gpio phandle for reading the otg id pin value @@ -37,6 +40,7 @@ Optional properties: - usb0_vbus-supply : regulator phandle for controller usb0 vbus - usb1_vbus-supply : regulator phandle for controller usb1 vbus - usb2_vbus-supply : regulator phandle for controller usb2 vbus +- usb3_vbus-supply : regulator phandle for controller usb3 vbus Example: usbphy: phy@0x01c13400 {
The Allwinner H3 SoC has 4 USB PHYs, so it needs four sets of pmu regions, clocks, resets, and optional vbus properties. These were not described when the H3 compatible string was added. Fixes: 626a630e003c ("phy-sun4i-usb: Add support for the host usb-phys found on the H3 SoC") Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)