| Message ID | 1502372823-31706-1-git-send-email-sebastien.szymanski@armadeus.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Thu, 10 Aug 2017 15:47:02 +0200, Sébastien Szymanski wrote: > From: Adam Duskett <Aduskett@gmail.com> > > Signed-off-by: Adam Duskett <aduskett@gmail.com> > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > (cherry picked from commit 29f0bd345bde90fcf0060c33623ade34fa9c288c) > Change site to https to avoid a redirection. > > Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com> What is the justification for bumping dbus in the 2017.02.x maintenance branch ? This seems like an invasive change. If it's just to avoid the delay issue with expat 2.2.1, why not backport the dbus patch on 1.10.16 ? Best regards, Thomas
Hello, > On 14 Aug 2017, at 22:44, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > > Hello, > > On Thu, 10 Aug 2017 15:47:02 +0200, Sébastien Szymanski wrote: >> From: Adam Duskett <Aduskett@gmail.com> >> >> Signed-off-by: Adam Duskett <aduskett@gmail.com> >> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> >> >> (cherry picked from commit 29f0bd345bde90fcf0060c33623ade34fa9c288c) >> Change site to https to avoid a redirection. >> >> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com> > > What is the justification for bumping dbus in the 2017.02.x maintenance > branch ? This seems like an invasive change. > > If it's just to avoid the delay issue with expat 2.2.1, why not > backport the dbus patch on 1.10.16 ? No particular reason, I just thought it would be easier to backport the dbus patch on the version 1.10.22 as it is applied on this version on the master branch, rather than backporting it on dbus version 1.10.16. Best regards, > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
Hello, On Tue, 15 Aug 2017 21:01:51 +0200, Sébastien Szymanski wrote: > No particular reason, I just thought it would be easier to backport > the dbus patch on the version 1.10.22 as it is applied on this > version on the master branch, rather than backporting it on dbus > version 1.10.16. To change things in a LTS branch such as 2017.02.x, we need a much more solid reason than just "no particular reason". So I think we need a backport of the dbus patch working around the expat related issues on top of 1.10.16, instead of bumping dbus to 1.10.22. Best regards, Thomas
Hello, On Tue, 15 Aug 2017 21:45:37 +0200, Thomas Petazzoni wrote: > On Tue, 15 Aug 2017 21:01:51 +0200, Sébastien Szymanski wrote: > > > No particular reason, I just thought it would be easier to backport > > the dbus patch on the version 1.10.22 as it is applied on this > > version on the master branch, rather than backporting it on dbus > > version 1.10.16. > > To change things in a LTS branch such as 2017.02.x, we need a much more > solid reason than just "no particular reason". > > So I think we need a backport of the dbus patch working around the > expat related issues on top of 1.10.16, instead of bumping dbus to > 1.10.22. Following this discussion, I have marked your two patches as Changes Requested in patchwork. Please respin an updated version that takes into account the comment if you want such patches to be merged. Thanks a lot! Thomas
diff --git a/package/dbus/dbus.hash b/package/dbus/dbus.hash index af8143d..b005242 100644 --- a/package/dbus/dbus.hash +++ b/package/dbus/dbus.hash @@ -1,2 +1,3 @@ # Locally calculated after checking pgp signature -sha256 a7b0ba6ea3e8d0e08afec5e3030d0245614268276620c536726f8fa6e5c43388 dbus-1.10.16.tar.gz +# http://dbus.freedesktop.org/releases/dbus/dbus-1.10.22.tar.gz.asc +sha256 e2b1401e3eedc7b5c9a2034d31254c886e1fcbc7858006e0a1c59158fe4b7b97 dbus-1.10.22.tar.gz diff --git a/package/dbus/dbus.mk b/package/dbus/dbus.mk index 66b90bc..e05fbff 100644 --- a/package/dbus/dbus.mk +++ b/package/dbus/dbus.mk @@ -4,8 +4,8 @@ # ################################################################################ -DBUS_VERSION = 1.10.16 -DBUS_SITE = http://dbus.freedesktop.org/releases/dbus +DBUS_VERSION = 1.10.22 +DBUS_SITE = https://dbus.freedesktop.org/releases/dbus DBUS_LICENSE = AFLv2.1 or GPLv2+ (library, tools), GPLv2+ (tools) DBUS_LICENSE_FILES = COPYING DBUS_INSTALL_STAGING = YES