system.h and system header include cleanup

As I indicated in <http://gcc.gnu.org/ml/gcc/2010-11/msg00587.html>,
rather too many places have accumulated with system headers directly
included in individual source files rather than in system.h.  It is
generally preferred to have host system dependencies and header
includes in system.h, at least if they are used several times in GCC,
rather than spreading conditional code allowing for such dependencies
about the compiler.

This patch cleans up such issues somewhat (for code built for the host
and build systems; though tsystem.h exists for code built for the
target, I didn't do anything about such code).  system.h is made to
include four more headers: <signal.h>, <sys/mman.h>, <sys/resource.h>
and <sys/times.h>.  Associated macros that were defined in multiple
places in the compiler are added, including O_BINARY.  Includes and
definitions directly in individual source files - including those of
system headers (and libiberty.h) already included in system.h, or
system header includes not in fact needed - were removed.  Some system
header includes removed from target files came before config.h,
meaning there could have been large-files issues on those targets
before this patch; config.h must *always* be the first include in any
file that includes, directly or indirectly, any system header.

GET_ENVIRONMENT was a macro in defaults.h that appeared to be intended
to encapsulate some form of system dependency (and so would belong in
system.h), but since there were no non-default definitions of this
macro and plenty of plain uses of getenv, I changed all uses of
GET_ENVIRONMENT to use getenv and poisoned the macro.  One tm.h
include that was commented as present for GET_ENVIRONMENT was removed;
makefile dependencies didn't mention that include so didn't need
updating.

A configure test for mincore was removed since the only use of the
result of that test was to condition includes of <sys/types.h>, which
is already included in system.h.

fortran/gfortran.h had a pile of definitions related to alloca.  If
such were needed, system.h would be the right place for them, but
since the rest of GCC uses alloca without needing such definitions I
just removed them.

java/jcf-depend.c was made to use gcc_assert instead of <assert.h>.

lto/lto-endian.h (which included some system headers) was removed as
unused.

In the course of doing this I noticed et-forest.h makes use of 'extern
"C"'; I see no reason for it to do so (given the general convention we
have that GCC-internal interfaces are C++ interfaces when building as
C++), but didn't change it.

To make it easier to find system header includes I changed some code
to follow the convention that #include <> is used for system headers
but #include "" for GCC headers (including those in libiberty).

Bootstrapped with no regressions on x86_64-unknown-linux-gnu.  Also
tested building cc1 for crosses to: alpha-linux-gnu arm-eabi frv-elf
i686-mingw32 iq2000-elf m32c-elf m68hc11-elf mep-elf microblaze-elf
mips-elf.  OK to commit?

2010-11-26  Joseph Myers  <joseph@codesourcery.com>

	* system.h: Include "safe-ctype.h" instead of <safe-ctype.h>.
	Include <signal.h>, <sys/mman.h>, <sys/resource.h> and
	<sys/times.h>.
	(O_BINARY, SIGCHLD, MAP_FAILED, MAP_ANONYMOUS, kill):
	Conditionally define.
	(GET_ENVIRONMENT): Poison.
	* configure.ac: Don't test for mincore.
	* configure: Regenerate.
	* config.in: Regenerate.
	* collect2-aix.c: Don't include <sys/mman.h>.
	* collect2.c: Don't include <signal.h>.
	(SIGCHLD): Don't define.
	(prefix_from_env): Use getenv instead of GET_ENVIRONMENT.
	* config/alpha/alpha.c: Include "splay-tree.h" instead of
	<splay-tree.h>.
	* config/arm/arm.c (arm_target_help): Use getenv instead of
	GET_ENVIRONMENT.
	* config/avr/driver-avr.c: Don't include <stdlib.h>.
	* config/frv/frv.c: Don't include <ctype.h>.
	* config/host-darwin.c: Don't include <sys/mman.h>.
	* config/host-hpux.c: Don't include <sys/mman.h> or <unistd.h>.
	(MAP_FAILED): Don't define.
	* config/host-linux.c: Don't include <sys/mman.h> or <limits.h>.
	* config/host-solaris.c: Don't include <sys/mman.h>.
	* config/i386/cygming.h: Don't include <stdio.h>.
	* config/i386/driver-i386.c: Don't include <stdlib.h>.
	* config/i386/host-cygwin.c: Don't include <sys/mman.h>.
	* config/iq2000/iq2000.c: Don't include <signal.h>.
	* config/m32c/m32c-pragma.c: Don't include <stdio.h>.
	* config/m68hc11/m68hc11.c: Don't include <stdio.h>.
	* config/mep/mep-pragma.c: Don't include <stdio.h>.
	* config/microblaze/microblaze.c: Don't include <signal.h>.
	* config/mips/mips.c: Don't include <signal.h>.
	* config/rs6000/host-darwin.c: Don't include <signal.h>.
	* cppdefault.c (cpp_relocated): Use getenv instead of
	GET_ENVIRONMENT.
	* defaults.h (GET_ENVIRONMENT): Don't define.
	* et-forest.h: Don't include <ansidecl.h> or <stddef.h>.
	* gcc.c: Don't include <signal.h>, <sys/mman.h> or <sys/types.h>.
	(SIGCHLD, MAP_FAILED, kill): Don't define.
	(process_command): Use getenv instead of GET_ENVIRONMENT.
	* genhooks.c: Don't include <string.h>.
	* ggc-common.c: Don't include <sys/resource.h>, <sys/mman.h> or
	<sys/types.h>.
	(MAP_FAILED): Don't define.
	* ggc-page.c Don't include <sys/mman.h>.
	(MAP_ANONYMOUS, MAP_FAILED): Don't define.
	* ggc-zone.c: Don't include <sys/mman.h>.
	(MAP_ANONYMOUS, MAP_FAILED): Don't define.
	* graph.c: Include "config.h" instead of <config.h>.
	* incpath.c (add_env_var_paths): Use getenv instead of
	GET_ENVIRONMENT.
	* lto-wrapper.c: Don't include <errno.h>, <signal.h> or
	"libiberty.h".
	(SIGCHLD, kill): Don't define.
	* mips-tfile.c: Don't include <signal.h>.
	* opts.c: Don't include <signal.h> or <sys/resource.h>.
	(print_specific_help): Use getenv instead of GET_ENVIRONMENT.
	* passes.c: Don't include <signal.h>, <sys/resource.h> or
	<sys/times.h>.
	* sparseset.h: Don't include <assert.h>.
	* timevar.c: Don't include <sys/times.h> or <sys/resource.h>.
	* tlink.c: Don't include "libiberty.h".
	* toplev.c: Don't include <signal.h> or <sys/times.h>.
	* tree-mudflap.c: Include "demangle.h" instead of <demangle.h>.
	* tree-switch-conversion.c: Don't include <signal.h>.
	* vmsdbgout.c: Don't include <errno.h> or <string.h>.

c-family:
2010-11-26  Joseph Myers  <joseph@codesourcery.com>

	* c-opts.c (check_deps_environment_vars): Use getenv instead of
	GET_ENVIRONMENT.
	* c-pch.c (O_BINARY): Don't define here.
	* c-pragma.h: Include "cpplib.h" instead of <cpplib.h>.

fortran:
2010-11-26  Joseph Myers  <joseph@codesourcery.com>

	* gfortran.h (alloca): Don't include definitions.
	(NULL): Don't define.

java:
2010-11-26  Joseph Myers  <joseph@codesourcery.com>

	* boehm.c: Include "config.h" instead of <config.h>.
	* builtins.c: Don't include <stdarg.h>.
	* class.c: Don't include "stdio.h".
	(O_BINARY): Don't define here.
	* jcf-depend.c: Don't include <assert.h>.
	(jcf_dependency_set_dep_file, jcf_dependency_init,
	jcf_dependency_write): Use gcc_assert.
	* jcf-io.c (O_BINARY): Don't define here.
	* jcf-path.c: Don't include "tm.h".
	(jcf_path_init): Use getenv instead of GET_ENVIRONMENT.
	* resource.c: Don't include "stdio.h".
	(O_BINARY): Don't define here.
	* verify-impl.c: Don't include <stdio.h>.

lto:
2010-11-26  Joseph Myers  <joseph@codesourcery.com>

	* lto-endian.h: Delete.
	* lto-object.c: Don't include "libiberty.h".
	(O_BINARY): Don't define.
	* lto.c: Don't include "libiberty.h" or <sys/mman.h>.
	(O_BINARY): Don't define.

system.h and system header include cleanup

Commit Message

Comments

Patch