Message ID | 20170809213550.rga6tlohagu2pm2y@mwanda |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Thu, Aug 10, 2017 at 12:35:50AM +0300, Dan Carpenter wrote: > "ret" isn't necessarily initialized here. > > Fixes: 9525ae83959b ("phylink: add phylink infrastructure") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Thu, 10 Aug 2017 00:35:50 +0300 > "ret" isn't necessarily initialized here. > > Fixes: 9525ae83959b ("phylink: add phylink infrastructure") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied, thanks Dan.
On Thu, Aug 10, 2017 at 05:21:12PM +0200, Andrew Lunn wrote: > On Thu, Aug 10, 2017 at 12:35:50AM +0300, Dan Carpenter wrote: > > "ret" isn't necessarily initialized here. > > > > Fixes: 9525ae83959b ("phylink: add phylink infrastructure") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Thanks, not sure how that got missed - it was probably introduced when migrating the code to ksettings.
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 32917bdd1432..bcb4755bcd95 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -958,7 +958,7 @@ int phylink_ethtool_ksettings_set(struct phylink *pl, } mutex_unlock(&pl->state_mutex); - return ret; + return 0; } EXPORT_SYMBOL_GPL(phylink_ethtool_ksettings_set);
"ret" isn't necessarily initialized here. Fixes: 9525ae83959b ("phylink: add phylink infrastructure") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>