Message ID | cover.1501509525.git.horms+renesas@verge.net.au |
---|---|
State | New |
Headers | show |
On 07/31/2017 06:03 PM, Simon Horman wrote: > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > This patch adds the "companion" property in the EHCI ch0, ch1 and > ch2 nodes to wait for the usb companion controller startup at resume. > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > [remove ch3 node and revise the commit log] > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > index d73d986039c8..7246e689b619 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -1583,6 +1583,7 @@ > clocks = <&cpg CPG_MOD 703>; > phys = <&usb2_phy0>; > phy-names = "usb"; > + companion= <&ohci0>; > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > resets = <&cpg 703>; > status = "disabled"; > @@ -1595,6 +1596,7 @@ > clocks = <&cpg CPG_MOD 702>; > phys = <&usb2_phy1>; > phy-names = "usb"; > + companion= <&ohci1>; > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > resets = <&cpg 702>; > status = "disabled"; > @@ -1607,6 +1609,7 @@ > clocks = <&cpg CPG_MOD 701>; > phys = <&usb2_phy2>; > phy-names = "usb"; > + companion= <&ohci2>; > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > resets = <&cpg 701>; > status = "disabled"; Looks like a space before = is missing in all 3 cases. MBR, Sergei
On Mon, Jul 31, 2017 at 07:40:23PM +0300, Sergei Shtylyov wrote: > On 07/31/2017 06:03 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > > >This patch adds the "companion" property in the EHCI ch0, ch1 and > >ch2 nodes to wait for the usb companion controller startup at resume. > > > >Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > >Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >[remove ch3 node and revise the commit log] > >Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >--- > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++ > > 1 file changed, 3 insertions(+) > > > >diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > >index d73d986039c8..7246e689b619 100644 > >--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > >+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > >@@ -1583,6 +1583,7 @@ > > clocks = <&cpg CPG_MOD 703>; > > phys = <&usb2_phy0>; > > phy-names = "usb"; > >+ companion= <&ohci0>; > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > resets = <&cpg 703>; > > status = "disabled"; > >@@ -1595,6 +1596,7 @@ > > clocks = <&cpg CPG_MOD 702>; > > phys = <&usb2_phy1>; > > phy-names = "usb"; > >+ companion= <&ohci1>; > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > resets = <&cpg 702>; > > status = "disabled"; > >@@ -1607,6 +1609,7 @@ > > clocks = <&cpg CPG_MOD 701>; > > phys = <&usb2_phy2>; > > phy-names = "usb"; > >+ companion= <&ohci2>; > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > resets = <&cpg 701>; > > status = "disabled"; > > Looks like a space before = is missing in all 3 cases. Thanks. I'll post a follow-up patch for that. I don't think it warrants respinning this pull request at this point.
On Wed, Aug 02, 2017 at 02:20:59PM +0200, Simon Horman wrote: > On Mon, Jul 31, 2017 at 07:40:23PM +0300, Sergei Shtylyov wrote: > > On 07/31/2017 06:03 PM, Simon Horman wrote: > > > > >From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > > > > >This patch adds the "companion" property in the EHCI ch0, ch1 and > > >ch2 nodes to wait for the usb companion controller startup at resume. > > > > > >Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > >Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >[remove ch3 node and revise the commit log] > > >Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > >--- > > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > >diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > >index d73d986039c8..7246e689b619 100644 > > >--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > >+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > >@@ -1583,6 +1583,7 @@ > > > clocks = <&cpg CPG_MOD 703>; > > > phys = <&usb2_phy0>; > > > phy-names = "usb"; > > >+ companion= <&ohci0>; > > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > > resets = <&cpg 703>; > > > status = "disabled"; > > >@@ -1595,6 +1596,7 @@ > > > clocks = <&cpg CPG_MOD 702>; > > > phys = <&usb2_phy1>; > > > phy-names = "usb"; > > >+ companion= <&ohci1>; > > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > > resets = <&cpg 702>; > > > status = "disabled"; > > >@@ -1607,6 +1609,7 @@ > > > clocks = <&cpg CPG_MOD 701>; > > > phys = <&usb2_phy2>; > > > phy-names = "usb"; > > >+ companion= <&ohci2>; > > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > > resets = <&cpg 701>; > > > status = "disabled"; > > > > Looks like a space before = is missing in all 3 cases. > > Thanks. > > I'll post a follow-up patch for that. I don't think it warrants respinning > this pull request at this point. Follow-up sent as [PATCH] arm64: dts: renesas: r8a7795: correct whitespace of companion property
On Mon, Jul 31, 2017 at 5:03 PM, Simon Horman <horms+renesas@verge.net.au> wrote: > ---------------------------------------------------------------- > Renesas ARM64 Based SoC DT Updates for v4.14 > > * Add usb2.0 for R-Car H3 (r8a7795) ES2.0 SoC > > * Add R-Car D3 (r8a77995) SoC and Draak board support > > Adds minimal support for the R-Car D3 SoC and the Draak development > board, allowing to boot from a ramdisk using a serial console. > > * Add Add VC6 clock generator to R-Car H3 (r8a7795)/Salvator-XS board > > The VC6 is an I2C-controlled programmable clock generator, used on the > board to provide a display dot clock. Add it to DT. > > * Add missing second pair of DMA names to MSIOF nodes to > R-Car M3-W (r8a7796) SoC > > MSIOF0 and MSIOF1 are tied to two DMA controllers through two pairs of > DMA specifiers. However, the second pair of corresponding DMA names was > missing. > > * Add support for the DU to R-Car H3 (r8a7795) SoC > > Add a compatible string and VSP links to the DU node. The H3 ES1.x and H3 > ES2.0 are compatible save for the links to the VSPs that are described > explicitly in DT, so there's no need for a new ES2-specific compatible > string. > > * Enable HDMI on R-Car H3 (r8a7795) and M3-W (r8a7796) ULCB boards > > * Enable DU on R-Car M3-W (r8a7796) Salvator-X board > > * Enable I2C for DVFS on R-Car H3 (r8a7795) and M3-W (r8a7796) ULCB boards > > * Add Add DRIF support to R-Car H3 (r8a7795) and M3-W (r8a7796) SoCs > > Ramesh Shanmugasundaram says, "R-Car Gen3 DRIF is a SPI like receive only > slave device." > > * Move CPG_AUDIO_CLK_I from board to soc files > > Geert Uytterhoeven says, "The definition of CPG_AUDIO_CLK_I is > SoC-specific, not board-specific." > > * Add IMR-LX4 support to R-Car H3 (r8a7795) and M3-W (r8a7796) SoCs > > Sergei Shtylyov says, "The image renderer light extended 4 (IMR-LX4) or > the distortion correction engine is a drawing processor with a simple > instruction system capable of referencing data on an external memory as > 2D texture data and performing texture mapping and drawing with respect > to any shape that is split into triangular objects." Pulled into next/dt64, thanks! Arnd