diff mbox

[v2] correct migrate_set_speed's args_type

Message ID 4CEDB67D.9070904@cn.fujitsu.com
State New
Headers show

Commit Message

Wen Congyang Nov. 25, 2010, 1:06 a.m. UTC
The args_type of migrate_set_speed in qmp-commands.hx is wrong.
When we set migrate speed by json, qemu will be core dumped.

This bug was caused by 07de3e60b05 and hence affects master only.

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>

---
 qmp-commands.hx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 1.7.1

Comments

Luiz Capitulino Nov. 25, 2010, 1:29 p.m. UTC | #1
On Thu, 25 Nov 2010 09:06:05 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:

> The args_type of migrate_set_speed in qmp-commands.hx is wrong.
> When we set migrate speed by json, qemu will be core dumped.
> 
> This bug was caused by 07de3e60b05 and hence affects master only.
> 
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>

Applied, thanks.

> 
> ---
>  qmp-commands.hx |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 793cf1c..16bdb08 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -495,7 +495,7 @@ EQMP
>  
>      {
>          .name       = "migrate_set_speed",
> -        .args_type  = "value:f",
> +        .args_type  = "value:o",
>          .params     = "value",
>          .help       = "set maximum speed (in bytes) for migrations",
>          .user_print = monitor_user_noop,
> -- 1.7.1 
>
diff mbox

Patch

diff --git a/qmp-commands.hx b/qmp-commands.hx
index 793cf1c..16bdb08 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -495,7 +495,7 @@  EQMP
 
     {
         .name       = "migrate_set_speed",
-        .args_type  = "value:f",
+        .args_type  = "value:o",
         .params     = "value",
         .help       = "set maximum speed (in bytes) for migrations",
         .user_print = monitor_user_noop,