| Message ID | 1500464893-11352-5-git-send-email-absahu@codeaurora.org |
|---|---|
| State | Superseded |
| Delegated to: | Boris Brezillon |
| Headers | show |
On Wed, Jul 19, 2017 at 05:17:52PM +0530, Abhishek Sahu wrote: > The current compatible string “qcom,ipq806x-nand" implies that > the driver is specific to IPQ806x. This driver can be used by > any chip which uses EBI2 NAND controller so changed the > compatible string to “qcom,ebi2-nandc” to give it more generic > name. > > Since there is no user for this driver currently in so > changing compatible string is safe. > > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> > --- > Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > index 70dd511..4511918 100644 > --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > @@ -1,7 +1,9 @@ > * Qualcomm NAND controller > > Required properties: > -- compatible: should be "qcom,ipq806x-nand" > +- compatible: should be "qcom,ebi2-nandc" - EBI2 NAND which uses ADM > + DMA like IPQ8064. Compatible strings are supposed to be specific to the SoC. The old one wasn't quite and the new one moves in the wrong direction. Rob
diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt index 70dd511..4511918 100644 --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt @@ -1,7 +1,9 @@ * Qualcomm NAND controller Required properties: -- compatible: should be "qcom,ipq806x-nand" +- compatible: should be "qcom,ebi2-nandc" - EBI2 NAND which uses ADM + DMA like IPQ8064. + - reg: MMIO address range - clocks: must contain core clock and always on clock - clock-names: must contain "core" for the core clock and "aon" for the
The current compatible string “qcom,ipq806x-nand" implies that the driver is specific to IPQ806x. This driver can be used by any chip which uses EBI2 NAND controller so changed the compatible string to “qcom,ebi2-nandc” to give it more generic name. Since there is no user for this driver currently in so changing compatible string is safe. Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> --- Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)