diff mbox

support/testing: fix TestExt4 after ext2fs refactoring

Message ID 20170710214531.15758-1-arnout@mind.be
State Superseded
Headers show

Commit Message

Arnout Vandecappelle July 10, 2017, 9:45 p.m. UTC
Commit bee9e881a2d3addd6880b39f3e33a7180d0b1eb4 removed the
BR2_TARGET_ROOTFS_EXT2_BLOCKS but didn't update TestExt4 that uses
(tests) that option.

Convert it to BR2_TARGET_ROOTFS_EXT2_SIZE, using 16M so the M gets
tested as well.

Fixes: https://gitlab.com/arnout/buildroot/-/jobs/21910153

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 support/testing/tests/fs/test_ext.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ricardo Martincoski July 15, 2017, 3:04 a.m. UTC | #1
Hello,

On Mon, Jul 10, 2017 at 06:45 PM, Arnout Vandecappelle (Essensium/Mind) wrote:

> Commit bee9e881a2d3addd6880b39f3e33a7180d0b1eb4 removed the
> BR2_TARGET_ROOTFS_EXT2_BLOCKS but didn't update TestExt4 that uses
> (tests) that option.
> 
> Convert it to BR2_TARGET_ROOTFS_EXT2_SIZE, using 16M so the M gets
> tested as well.

http://patchwork.ozlabs.org/patch/788595/
that does not use the M, was applied instead.
Both generate a rootfs with size 16777216 bytes.

Regards,
Ricardo
Yann E. MORIN July 15, 2017, 10:35 a.m. UTC | #2
Ricardo, Arnout, All,

On 2017-07-15 00:04 -0300, Ricardo Martincoski spake thusly:
> On Mon, Jul 10, 2017 at 06:45 PM, Arnout Vandecappelle (Essensium/Mind) wrote:
> 
> > Commit bee9e881a2d3addd6880b39f3e33a7180d0b1eb4 removed the
> > BR2_TARGET_ROOTFS_EXT2_BLOCKS but didn't update TestExt4 that uses
> > (tests) that option.
> > 
> > Convert it to BR2_TARGET_ROOTFS_EXT2_SIZE, using 16M so the M gets
> > tested as well.
> 
> http://patchwork.ozlabs.org/patch/788595/
> that does not use the M, was applied instead.

Oh, sorry Aernout, I did not notice your patch before sending mine...

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/support/testing/tests/fs/test_ext.py b/support/testing/tests/fs/test_ext.py
index 34321a3995..733c7469f2 100644
--- a/support/testing/tests/fs/test_ext.py
+++ b/support/testing/tests/fs/test_ext.py
@@ -97,7 +97,7 @@  class TestExt4(infra.basetest.BRTest):
 """
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
-BR2_TARGET_ROOTFS_EXT2_BLOCKS=16384
+BR2_TARGET_ROOTFS_EXT2_SIZE="16M"
 BR2_TARGET_ROOTFS_EXT2_INODES=3000
 BR2_TARGET_ROOTFS_EXT2_RESBLKS=10
 # BR2_TARGET_ROOTFS_TAR is not set