| Message ID | 4CE56E89.4000902@trash.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 11/18/2010 10:20 AM, Patrick McHardy wrote: > Am 18.11.2010 19:13, schrieb Justin P. Mattock: >> On 11/18/2010 09:50 AM, David Miller wrote: >>> From: Eric Dumazet<eric.dumazet@gmail.com> >>> Date: Thu, 18 Nov 2010 18:48:17 +0100 >>> >>>> Let me guess... >>>> >>>> net/netfilter/nf_conntrack_core is compiled as a module, and ip_vs >>>> statically (in vmlinux) ? >>>> >>>> CONFIG_NF_CONNTRACK=m >>>> CONFIG_IP_VS=y >>>> >>>> We probably need some Kconfig magic ;) >>> > > Please try whether this patch fixes the problem. sure.. right now I'm rebuilding with conntract built-in as suggested by eric. then ill go back and test your patch out > > netfilter: fix IP_VS dependencies > > When NF_CONNTRACK is enabled, IP_VS uses conntrack symbols. > Therefore IP_VS can't be linked statically when conntrack > is built modular. > > Reported-by: Justin P. Mattock<justinmattock@gmail.com> > Signed-off-by: Patrick McHardy<kaber@trash.net> > > Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/18/2010 10:20 AM, Patrick McHardy wrote: > Am 18.11.2010 19:13, schrieb Justin P. Mattock: >> On 11/18/2010 09:50 AM, David Miller wrote: >>> From: Eric Dumazet<eric.dumazet@gmail.com> >>> Date: Thu, 18 Nov 2010 18:48:17 +0100 >>> >>>> Let me guess... >>>> >>>> net/netfilter/nf_conntrack_core is compiled as a module, and ip_vs >>>> statically (in vmlinux) ? >>>> >>>> CONFIG_NF_CONNTRACK=m >>>> CONFIG_IP_VS=y >>>> >>>> We probably need some Kconfig magic ;) >>> > > Please try whether this patch fixes the problem. > > netfilter: fix IP_VS dependencies > > When NF_CONNTRACK is enabled, IP_VS uses conntrack symbols. > Therefore IP_VS can't be linked statically when conntrack > is built modular. > > Reported-by: Justin P. Mattock<justinmattock@gmail.com> > Signed-off-by: Patrick McHardy<kaber@trash.net> > > alright!! doing the above change CONFIG_NF_CONNTRACK=y gets a clean build.. as well as reverting everything and using your patch.. Thanks for the fix.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 18.11.2010 20:18, schrieb Justin P. Mattock: > On 11/18/2010 10:20 AM, Patrick McHardy wrote: >> Am 18.11.2010 19:13, schrieb Justin P. Mattock: >>> On 11/18/2010 09:50 AM, David Miller wrote: >>>> From: Eric Dumazet<eric.dumazet@gmail.com> >>>> Date: Thu, 18 Nov 2010 18:48:17 +0100 >>>> >>>>> Let me guess... >>>>> >>>>> net/netfilter/nf_conntrack_core is compiled as a module, and ip_vs >>>>> statically (in vmlinux) ? >>>>> >>>>> CONFIG_NF_CONNTRACK=m >>>>> CONFIG_IP_VS=y >>>>> >>>>> We probably need some Kconfig magic ;) >>>> >> >> Please try whether this patch fixes the problem. >> >> netfilter: fix IP_VS dependencies >> >> When NF_CONNTRACK is enabled, IP_VS uses conntrack symbols. >> Therefore IP_VS can't be linked statically when conntrack >> is built modular. >> >> Reported-by: Justin P. Mattock<justinmattock@gmail.com> >> Signed-off-by: Patrick McHardy<kaber@trash.net> >> >> > > > alright!! doing the above change > CONFIG_NF_CONNTRACK=y gets a clean build.. as well as reverting > everything and using your patch.. > > Thanks for the fix.. Thanks for testing. Dave, please apply directly, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Patrick McHardy <kaber@trash.net> Date: Thu, 18 Nov 2010 21:32:11 +0100 > Thanks for testing. Dave, please apply directly, thanks! Done. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote: > From: Patrick McHardy <kaber@trash.net> > Date: Thu, 18 Nov 2010 21:32:11 +0100 > > > Thanks for testing. Dave, please apply directly, thanks! Dave, This patch does not fix the config/build error that I posted for linux-next. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Randy Dunlap <randy.dunlap@oracle.com> Date: Thu, 18 Nov 2010 13:03:18 -0800 > On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote: > >> From: Patrick McHardy <kaber@trash.net> >> Date: Thu, 18 Nov 2010 21:32:11 +0100 >> >> > Thanks for testing. Dave, please apply directly, thanks! > > Dave, > > This patch does not fix the config/build error that I posted for linux-next. And it has bugs, now when NF_CONNTRACT is set to "m" IPVS isn't offered at all. So I'm reverting. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: David Miller <davem@davemloft.net> Date: Thu, 18 Nov 2010 13:10:04 -0800 (PST) > From: Randy Dunlap <randy.dunlap@oracle.com> > Date: Thu, 18 Nov 2010 13:03:18 -0800 > >> On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote: >> >>> From: Patrick McHardy <kaber@trash.net> >>> Date: Thu, 18 Nov 2010 21:32:11 +0100 >>> >>> > Thanks for testing. Dave, please apply directly, thanks! >> >> Dave, >> >> This patch does not fix the config/build error that I posted for linux-next. > > And it has bugs, now when NF_CONNTRACT is set to "m" IPVS isn't offered > at all. > > So I'm reverting. Ignore this, I was looking for "*_IPVS" in the config instead of "*_IP_VS" for some stupid reason. Patch is sane and I'll look into Randy's problem when I get a chance. :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 18.11.2010 22:15, schrieb David Miller: > From: David Miller <davem@davemloft.net> > Date: Thu, 18 Nov 2010 13:10:04 -0800 (PST) > >> From: Randy Dunlap <randy.dunlap@oracle.com> >> Date: Thu, 18 Nov 2010 13:03:18 -0800 >> >>> On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote: >>> >>>> From: Patrick McHardy <kaber@trash.net> >>>> Date: Thu, 18 Nov 2010 21:32:11 +0100 >>>> >>>>> Thanks for testing. Dave, please apply directly, thanks! >>> >>> Dave, >>> >>> This patch does not fix the config/build error that I posted for linux-next. >> >> And it has bugs, now when NF_CONNTRACT is set to "m" IPVS isn't offered >> at all. >> >> So I'm reverting. > > Ignore this, I was looking for "*_IPVS" in the config instead of > "*_IP_VS" for some stupid reason. I always make the same mistake :) > Patch is sane and I'll look into Randy's problem when I get a chance. > :-) I've already asked the tproxy guys to look into this, it's a different problem that requires more tproxy knowledge than have. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/18/2010 01:48 PM, Patrick McHardy wrote: > Am 18.11.2010 22:15, schrieb David Miller: >> From: David Miller<davem@davemloft.net> >> Date: Thu, 18 Nov 2010 13:10:04 -0800 (PST) >> >>> From: Randy Dunlap<randy.dunlap@oracle.com> >>> Date: Thu, 18 Nov 2010 13:03:18 -0800 >>> >>>> On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote: >>>> >>>>> From: Patrick McHardy<kaber@trash.net> >>>>> Date: Thu, 18 Nov 2010 21:32:11 +0100 >>>>> >>>>>> Thanks for testing. Dave, please apply directly, thanks! >>>> >>>> Dave, >>>> >>>> This patch does not fix the config/build error that I posted for linux-next. >>> >>> And it has bugs, now when NF_CONNTRACT is set to "m" IPVS isn't offered >>> at all. >>> >>> So I'm reverting. >> >> Ignore this, I was looking for "*_IPVS" in the config instead of >> "*_IP_VS" for some stupid reason. > > I always make the same mistake :) > >> Patch is sane and I'll look into Randy's problem when I get a chance. >> :-) > > I've already asked the tproxy guys to look into this, it's a > different problem that requires more tproxy knowledge than > have. > go outside to clean the garage, and put up the christmas lights up, come back and am freaking for a second that the problems not fixed... tripping me out man!! Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 18, 2010 at 03:48:00PM -0800, Justin P. Mattock wrote: > On 11/18/2010 01:48 PM, Patrick McHardy wrote: > >Am 18.11.2010 22:15, schrieb David Miller: > >>From: David Miller<davem@davemloft.net> > >>Date: Thu, 18 Nov 2010 13:10:04 -0800 (PST) > >> > >>>From: Randy Dunlap<randy.dunlap@oracle.com> > >>>Date: Thu, 18 Nov 2010 13:03:18 -0800 > >>> > >>>>On Thu, 18 Nov 2010 12:54:51 -0800 (PST) David Miller wrote: > >>>> > >>>>>From: Patrick McHardy<kaber@trash.net> > >>>>>Date: Thu, 18 Nov 2010 21:32:11 +0100 > >>>>> > >>>>>>Thanks for testing. Dave, please apply directly, thanks! > >>>> > >>>>Dave, > >>>> > >>>>This patch does not fix the config/build error that I posted for linux-next. > >>> > >>>And it has bugs, now when NF_CONNTRACT is set to "m" IPVS isn't offered > >>>at all. > >>> > >>>So I'm reverting. > >> > >>Ignore this, I was looking for "*_IPVS" in the config instead of > >>"*_IP_VS" for some stupid reason. > > > >I always make the same mistake :) > > > >>Patch is sane and I'll look into Randy's problem when I get a chance. > >>:-) > > > >I've already asked the tproxy guys to look into this, it's a > >different problem that requires more tproxy knowledge than > >have. > > > > > go outside to clean the garage, and put up the christmas lights up, > come back and am freaking for a second that the problems not > fixed... > > tripping me out man!! On a similar note, sorry for not participating in the IPVS portion of this thread, it was all over by the time that I woke up this morning. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig index a22dac2..70bd1d0 100644 --- a/net/netfilter/ipvs/Kconfig +++ b/net/netfilter/ipvs/Kconfig @@ -4,6 +4,7 @@ menuconfig IP_VS tristate "IP virtual server support" depends on NET && INET && NETFILTER + depends on (NF_CONNTRACK || NF_CONNTRACK=n) ---help--- IP Virtual Server support will let you build a high-performance virtual server based on cluster of two or more real servers. This