| Message ID | cbd726c5aa26ea8278c518508ba76efc5b796f7a.1499592591.git.yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Sun, 9 Jul 2017 11:29:58 +0200, Yann E. MORIN wrote: > We have to specify the -mcpu value, even in 64-bit mode. > > For AArch64, +fp and +simd are the default, so they are totally useless. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Baruch Siach <baruch@tkos.co.il> > > --- > Changes v1 -> v2: > - squash the two changes into one patch (Thomas) > - remove useless parentheses (Baruch) > - remove superfluous indentation Applied to master, thanks. Thomas
Hi everybody, Please remove my e-mail from your exchange list. I just posted a ticket (ID 10011) for resolving the failure when Buildroot calls wget. Thank you for your understanding, Pavel Tomov (Mirion technologies) -----Original Message----- From: buildroot [mailto:buildroot-bounces@busybox.net] On Behalf Of Thomas Petazzoni Sent: Monday, July 10, 2017 9:05 AM To: Yann E. MORIN <yann.morin.1998@free.fr> Cc: buildroot@buildroot.org Subject: Re: [Buildroot] [PATCH 1/4 v3] arch/arm: fix -mcpu default values for AArch64 Hello, On Sun, 9 Jul 2017 11:29:58 +0200, Yann E. MORIN wrote: > We have to specify the -mcpu value, even in 64-bit mode. > > For AArch64, +fp and +simd are the default, so they are totally useless. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Baruch Siach <baruch@tkos.co.il> > > --- > Changes v1 -> v2: > - squash the two changes into one patch (Thomas) > - remove useless parentheses (Baruch) > - remove superfluous indentation Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Pavel, On 2017-07-10 16:18 +0000, Tomov, Pavel spake thusly: > Hi everybody, > > Please remove my e-mail from your exchange list. You may remove yourself from the list, by following the link that is repeated at the bottom of every message that comes from the list: http://lists.busybox.net/mailman/listinfo/buildroot Regards, Yann E. MORIN. > I just posted a ticket (ID 10011) for resolving the failure when Buildroot calls wget. > > Thank you for your understanding, > > Pavel Tomov > (Mirion technologies) > > -----Original Message----- > From: buildroot [mailto:buildroot-bounces@busybox.net] On Behalf Of Thomas Petazzoni > Sent: Monday, July 10, 2017 9:05 AM > To: Yann E. MORIN <yann.morin.1998@free.fr> > Cc: buildroot@buildroot.org > Subject: Re: [Buildroot] [PATCH 1/4 v3] arch/arm: fix -mcpu default values for AArch64 > > Hello, > > On Sun, 9 Jul 2017 11:29:58 +0200, Yann E. MORIN wrote: > > We have to specify the -mcpu value, even in 64-bit mode. > > > > For AArch64, +fp and +simd are the default, so they are totally useless. > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Cc: Baruch Siach <baruch@tkos.co.il> > > > > --- > > Changes v1 -> v2: > > - squash the two changes into one patch (Thomas) > > - remove useless parentheses (Baruch) > > - remove superfluous indentation > > Applied to master, thanks. > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering http://free-electrons.com _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > > ________________________________ > > PROPRIETARY INFORMATION NOTICE: This e-mail message and all attachments transmitted with it are intended solely for use by the addressee, may contain proprietary information of Mirion Technologies and/or its affiliates, and is subject to all applicable export controls. If the reader of this message is not the intended recipient, you are hereby notified that any review, dissemination, distribution, copying or other use of this message is strictly prohibited. If you have received this message in error, please notify the sender immediately by replying to the message, delete the original message and all attachments from your computer, and destroy any copies you may have made. Thank you.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > We have to specify the -mcpu value, even in 64-bit mode. > For AArch64, +fp and +simd are the default, so they are totally useless. > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Baruch Siach <baruch@tkos.co.il> Is this a candidate for 2017.02.x / 2017.05.x - In other words, what does it fix?
diff --git a/arch/Config.in.arm b/arch/Config.in.arm index b1817ed568..3cafe21700 100644 --- a/arch/Config.in.arm +++ b/arch/Config.in.arm @@ -534,15 +534,9 @@ config BR2_GCC_TARGET_CPU default "strongarm" if BR2_strongarm default "xscale" if BR2_xscale default "iwmmxt" if BR2_iwmmxt - default "cortex-a53" if (BR2_cortex_a53 && !BR2_ARCH_IS_64) - default "cortex-a53+fp" if (BR2_cortex_a53 && BR2_ARCH_IS_64 && BR2_ARM_FPU_FP_ARMV8) - default "cortex-a53+fp+simd" if (BR2_cortex_a53 && BR2_ARCH_IS_64 && BR2_ARM_FPU_NEON_FP_ARMV8) - default "cortex-a57" if (BR2_cortex_a57 && !BR2_ARCH_IS_64) - default "cortex-a57+fp" if (BR2_cortex_a57 && BR2_ARCH_IS_64 && BR2_ARM_FPU_FP_ARMV8) - default "cortex-a57+fp+simd" if (BR2_cortex_a57 && BR2_ARCH_IS_64 && BR2_ARM_FPU_NEON_FP_ARMV8) - default "cortex-a72" if (BR2_cortex_a72 && !BR2_ARCH_IS_64) - default "cortex-a72+fp" if (BR2_cortex_a72 && BR2_ARCH_IS_64 && BR2_ARM_FPU_FP_ARMV8) - default "cortex-a72+fp+simd" if (BR2_cortex_a72 && BR2_ARCH_IS_64 && BR2_ARM_FPU_NEON_FP_ARMV8) + default "cortex-a53" if BR2_cortex_a53 + default "cortex-a57" if BR2_cortex_a57 + default "cortex-a72" if BR2_cortex_a72 config BR2_GCC_TARGET_ABI default "aapcs-linux" if BR2_arm || BR2_armeb
We have to specify the -mcpu value, even in 64-bit mode. For AArch64, +fp and +simd are the default, so they are totally useless. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Baruch Siach <baruch@tkos.co.il> --- Changes v1 -> v2: - squash the two changes into one patch (Thomas) - remove useless parentheses (Baruch) - remove superfluous indentation Notes: If anything, it is the +nofp or +nosimd that should be specified. This can be done in a future patch, though. --- arch/Config.in.arm | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)