| Message ID | 1492689397-4704-2-git-send-email-clg@kaod.org |
|---|---|
| State | Accepted |
| Delegated to: | Cyrille Pitchen |
| Headers | show |
On 04/20/2017 01:56 PM, Cédric Le Goater wrote: > There is no need to keep the dummy bytes in the control register if > the command mode is not kept also. This could lead to an inconsistent > setting : normal read mode (command 0x3) and dummy bytes. It is to be > noted that the HW allows such a configuration. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Reviewed-by: Marek Vasut <marek.vasut@gmail.com> > --- > drivers/mtd/spi-nor/aspeed-smc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c > index 56051d30f000..2940f2098420 100644 > --- a/drivers/mtd/spi-nor/aspeed-smc.c > +++ b/drivers/mtd/spi-nor/aspeed-smc.c > @@ -180,8 +180,7 @@ struct aspeed_smc_controller { > > #define CONTROL_KEEP_MASK \ > (CONTROL_AAF_MODE | CONTROL_CE_INACTIVE_MASK | CONTROL_CLK_DIV4 | \ > - CONTROL_IO_DUMMY_MASK | CONTROL_CLOCK_FREQ_SEL_MASK | \ > - CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3) > + CONTROL_CLOCK_FREQ_SEL_MASK | CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3) > > /* > * The Segment Register uses a 8MB unit to encode the start address >
Le 20/04/2017 à 15:28, Marek Vasut a écrit : > On 04/20/2017 01:56 PM, Cédric Le Goater wrote: >> There is no need to keep the dummy bytes in the control register if >> the command mode is not kept also. This could lead to an inconsistent >> setting : normal read mode (command 0x3) and dummy bytes. It is to be >> noted that the HW allows such a configuration. >> >> Signed-off-by: Cédric Le Goater <clg@kaod.org> > > Reviewed-by: Marek Vasut <marek.vasut@gmail.com> > Applied to the spi-nor/next branch of l2-mtd Thanks! >> --- >> drivers/mtd/spi-nor/aspeed-smc.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c >> index 56051d30f000..2940f2098420 100644 >> --- a/drivers/mtd/spi-nor/aspeed-smc.c >> +++ b/drivers/mtd/spi-nor/aspeed-smc.c >> @@ -180,8 +180,7 @@ struct aspeed_smc_controller { >> >> #define CONTROL_KEEP_MASK \ >> (CONTROL_AAF_MODE | CONTROL_CE_INACTIVE_MASK | CONTROL_CLK_DIV4 | \ >> - CONTROL_IO_DUMMY_MASK | CONTROL_CLOCK_FREQ_SEL_MASK | \ >> - CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3) >> + CONTROL_CLOCK_FREQ_SEL_MASK | CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3) >> >> /* >> * The Segment Register uses a 8MB unit to encode the start address >> > >
diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c index 56051d30f000..2940f2098420 100644 --- a/drivers/mtd/spi-nor/aspeed-smc.c +++ b/drivers/mtd/spi-nor/aspeed-smc.c @@ -180,8 +180,7 @@ struct aspeed_smc_controller { #define CONTROL_KEEP_MASK \ (CONTROL_AAF_MODE | CONTROL_CE_INACTIVE_MASK | CONTROL_CLK_DIV4 | \ - CONTROL_IO_DUMMY_MASK | CONTROL_CLOCK_FREQ_SEL_MASK | \ - CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3) + CONTROL_CLOCK_FREQ_SEL_MASK | CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3) /* * The Segment Register uses a 8MB unit to encode the start address
There is no need to keep the dummy bytes in the control register if the command mode is not kept also. This could lead to an inconsistent setting : normal read mode (command 0x3) and dummy bytes. It is to be noted that the HW allows such a configuration. Signed-off-by: Cédric Le Goater <clg@kaod.org> --- drivers/mtd/spi-nor/aspeed-smc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)