pc: disable the BOCHS BIOS panic port

We have an OS which writes to port 0x400 when probing for special hardware.
This causes an exit of the VM. With SeaBIOS this port isn't used anyway.

Signed-off-by: Bernhard Kohl <bernhard.kohl@nsn.com>
---
 hw/pc.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Am 01.09.2010 16:44, schrieb Bernhard Kohl:
> We have an OS which writes to port 0x400 when probing for special hardware.
> This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
>
> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
> ---
>   hw/pc.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 69b13bf..3f81229 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -430,8 +430,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>           /* Bochs BIOS messages */
>       case 0x400:
>       case 0x401:
> -        fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
> -        exit(1);
>       case 0x402:
>       case 0x403:
>   #ifdef DEBUG_BIOS
>    

Hi,

could you please look at this?

Thanks
Bernhard

On 15.11.2010, at 10:53, Bernhard Kohl wrote:

> Am 01.09.2010 16:44, schrieb Bernhard Kohl:
>> We have an OS which writes to port 0x400 when probing for special hardware.
>> This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
>> 
>> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
>> ---
>>  hw/pc.c |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>> 
>> diff --git a/hw/pc.c b/hw/pc.c
>> index 69b13bf..3f81229 100644
>> --- a/hw/pc.c
>> +++ b/hw/pc.c
>> @@ -430,8 +430,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>>          /* Bochs BIOS messages */
>>      case 0x400:
>>      case 0x401:
>> -        fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
>> -        exit(1);
>>      case 0x402:
>>      case 0x403:
>>  #ifdef DEBUG_BIOS
>>   
> 
> Hi,
> 
> could you please look at this?

This patch makes that port that was silent before print debug output if DEBUG_BIOS is enabled which might be confusing.

How about something like

case 0x400:
case 0x401:
    /* used to be panic, now unused */
    break;


Alex

Am 15.11.2010 11:09, schrieb ext Alexander Graf:
> On 15.11.2010, at 10:53, Bernhard Kohl wrote:
>
>    
>> Am 01.09.2010 16:44, schrieb Bernhard Kohl:
>>      
>>> We have an OS which writes to port 0x400 when probing for special hardware.
>>> This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
>>>
>>> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
>>> ---
>>>   hw/pc.c |    2 --
>>>   1 files changed, 0 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hw/pc.c b/hw/pc.c
>>> index 69b13bf..3f81229 100644
>>> --- a/hw/pc.c
>>> +++ b/hw/pc.c
>>> @@ -430,8 +430,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>>>           /* Bochs BIOS messages */
>>>       case 0x400:
>>>       case 0x401:
>>> -        fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
>>> -        exit(1);
>>>       case 0x402:
>>>       case 0x403:
>>>   #ifdef DEBUG_BIOS
>>>
>>>        
>> Hi,
>>
>> could you please look at this?
>>      
> This patch makes that port that was silent before print debug output if DEBUG_BIOS is enabled which might be confusing.
>
> How about something like
>
> case 0x400:
> case 0x401:
>      /* used to be panic, now unused */
>      break;
>
>
> Alex
>
>
>    
Yes, you are right. I will take your proposal in patch v2.

Bernhard