| Message ID | 20170613195542.GA5677@embeddedgus |
|---|---|
| State | New |
| Headers | show |
On Tue, Jun 13, 2017 at 02:55:42PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary NULL check. > Pointer _chip_ cannot be NULL in this instance. > > Addresses-Coverity-ID: 1397646 > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/char/tpm/tpm_atmel.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c > index 0d322ab..66a1452 100644 > --- a/drivers/char/tpm/tpm_atmel.c > +++ b/drivers/char/tpm/tpm_atmel.c > @@ -144,13 +144,11 @@ static void atml_plat_remove(void) > struct tpm_chip *chip = dev_get_drvdata(&pdev->dev); > struct tpm_atmel_priv *priv = dev_get_drvdata(&chip->dev); > > - if (chip) { > - tpm_chip_unregister(chip); > - if (priv->have_region) > - atmel_release_region(priv->base, priv->region_size); > - atmel_put_base_addr(priv->iobase); > - platform_device_unregister(pdev); > - } > + tpm_chip_unregister(chip); > + if (priv->have_region) > + atmel_release_region(priv->base, priv->region_size); > + atmel_put_base_addr(priv->iobase); > + platform_device_unregister(pdev); > } > > static SIMPLE_DEV_PM_OPS(tpm_atml_pm, tpm_pm_suspend, tpm_pm_resume); > -- > 2.5.0 > Thank you. Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
On Tue, 2017-06-13 at 14:55 -0500, Gustavo A. R. Silva wrote: > Remove unnecessary NULL check. > Pointer _chip_ cannot be NULL in this instance. > > Addresses-Coverity-ID: 1397646 > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkine@linux.intel.com> Tested-by: Jarkko Sakkinen <jarkko.sakkine@linux.intel.com> (compilation) /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c index 0d322ab..66a1452 100644 --- a/drivers/char/tpm/tpm_atmel.c +++ b/drivers/char/tpm/tpm_atmel.c @@ -144,13 +144,11 @@ static void atml_plat_remove(void) struct tpm_chip *chip = dev_get_drvdata(&pdev->dev); struct tpm_atmel_priv *priv = dev_get_drvdata(&chip->dev); - if (chip) { - tpm_chip_unregister(chip); - if (priv->have_region) - atmel_release_region(priv->base, priv->region_size); - atmel_put_base_addr(priv->iobase); - platform_device_unregister(pdev); - } + tpm_chip_unregister(chip); + if (priv->have_region) + atmel_release_region(priv->base, priv->region_size); + atmel_put_base_addr(priv->iobase); + platform_device_unregister(pdev); } static SIMPLE_DEV_PM_OPS(tpm_atml_pm, tpm_pm_suspend, tpm_pm_resume);
Remove unnecessary NULL check. Pointer _chip_ cannot be NULL in this instance. Addresses-Coverity-ID: 1397646 Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/char/tpm/tpm_atmel.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)