| Message ID | 7e448554696af7d9952699fea79e4122ff6860af.1496072240.git.tredaelli@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
Acked-By: Miguel Angel Ajo <majopela@redhat.com> On Mon, May 29, 2017 at 5:37 PM, Timothy Redaelli <tredaelli@redhat.com> wrote: > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> > --- > rhel/openvswitch-fedora.spec.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora. > spec.in > index 3200040..9fc5f27 100644 > --- a/rhel/openvswitch-fedora.spec.in > +++ b/rhel/openvswitch-fedora.spec.in > @@ -279,9 +279,9 @@ install -p -m 644 -D selinux/openvswitch-custom.pp \ > $RPM_BUILD_ROOT%{_datadir}/selinux/packages/%{name}/ > openvswitch-custom.pp > > install -d $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ > -install rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml > \ > +install -p -m 0644 rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml > \ > $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn- > central-firewall-service.xml > -install rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml \ > +install -p -m 0644 rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml > \ > $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn-host- > firewall-service.xml > > # remove unpackaged files > -- > 2.9.4 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
> From: "Timothy Redaelli" <tredaelli@redhat.com> > To: dev@openvswitch.org > Sent: Monday, 29 May, 2017 11:37:26 AM > Subject: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644 instead of 755 > > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> > --- LGTM, but I think it also needs: Fixes: 55f36be59122 ("rhel: Firewall service files for OVN.") Lance
Thanks, I applied this to master and branch-2.7. On Tue, May 30, 2017 at 09:15:51AM +0200, Miguel Angel Ajo Pelayo wrote: > Acked-By: Miguel Angel Ajo <majopela@redhat.com> > > > > On Mon, May 29, 2017 at 5:37 PM, Timothy Redaelli <tredaelli@redhat.com> > wrote: > > > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> > > --- > > rhel/openvswitch-fedora.spec.in | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora. > > spec.in > > index 3200040..9fc5f27 100644 > > --- a/rhel/openvswitch-fedora.spec.in > > +++ b/rhel/openvswitch-fedora.spec.in > > @@ -279,9 +279,9 @@ install -p -m 644 -D selinux/openvswitch-custom.pp \ > > $RPM_BUILD_ROOT%{_datadir}/selinux/packages/%{name}/ > > openvswitch-custom.pp > > > > install -d $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ > > -install rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml > > \ > > +install -p -m 0644 rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml > > \ > > $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn- > > central-firewall-service.xml > > -install rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml \ > > +install -p -m 0644 rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml > > \ > > $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn-host- > > firewall-service.xml > > > > # remove unpackaged files > > -- > > 2.9.4 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, May 30, 2017 at 08:13:02AM -0400, Lance Richardson wrote: > > From: "Timothy Redaelli" <tredaelli@redhat.com> > > To: dev@openvswitch.org > > Sent: Monday, 29 May, 2017 11:37:26 AM > > Subject: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644 instead of 755 > > > > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> > > --- > > LGTM, but I think it also needs: > > Fixes: 55f36be59122 ("rhel: Firewall service files for OVN.") Thanks, I applied this to master and branch-2.7 and added that line.
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 3200040..9fc5f27 100644 --- a/rhel/openvswitch-fedora.spec.in +++ b/rhel/openvswitch-fedora.spec.in @@ -279,9 +279,9 @@ install -p -m 644 -D selinux/openvswitch-custom.pp \ $RPM_BUILD_ROOT%{_datadir}/selinux/packages/%{name}/openvswitch-custom.pp install -d $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ -install rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml \ +install -p -m 0644 rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml \ $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn-central-firewall-service.xml -install rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml \ +install -p -m 0644 rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml \ $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn-host-firewall-service.xml # remove unpackaged files
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> --- rhel/openvswitch-fedora.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)