diff mbox

MinGW compilation warnings in libiberty's waitpid.c

Message ID xnwp9cgvuu.fsf@greed.delorie.com
State New
Headers show

Commit Message

DJ Delorie May 20, 2017, 1:28 a.m. UTC 
Please try this patch, since my mingw environment is old:

Comments

Eli Zaretskii May 21, 2017, 3:31 p.m. UTC | #1 
> From: DJ Delorie <dj@redhat.com>
> Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
> Date: Fri, 19 May 2017 21:28:25 -0400
> 
> 
> Please try this patch, since my mingw environment is old:
> 
> Index: libiberty/ChangeLog
> ===================================================================
> --- libiberty/ChangeLog (revision 248307)
> +++ libiberty/ChangeLog (working copy)
> @@ -1,3 +1,7 @@
> +2017-05-19  Eli Zaretskii <eliz@gnu.org>
> +
> +       * configure.ac (*-*-mingw*): Don't build waitpid.c.
> +
>  2017-05-02  Iain Buclaw  <ibuclaw@gdcproject.org>
>  
>         * d-demangle.c (dlang_hexdigit): New function.
> Index: libiberty/configure.ac
> ===================================================================
> --- libiberty/configure.ac      (revision 248307)
> +++ libiberty/configure.ac      (working copy)
> @@ -493,7 +493,6 @@
>      AC_LIBOBJ([strnlen])
>      AC_LIBOBJ([strverscmp])
>      AC_LIBOBJ([vasprintf])
> -    AC_LIBOBJ([waitpid])
>  
>      for f in $funcs; do
>        case "$f" in
> 

Hmm... no, this doesn't solve the problem.  The expansion of AC_LIBOBJ
for waitpid is gone from the configure script, but the value of
LIBOBJS in libiberty/Makefile still includes waitpid.o.  What else is
related to this?

One caveat: I needed to hack config/override.m4 to allow me to run
autoconf 2.69 I have installed, because otherwise it insists on
autoconf 2.64 which I don't have.  I hope this isn't the reason for
the incomplete solution.
diff mbox

Patch

Index: libiberty/ChangeLog
===================================================================
--- libiberty/ChangeLog (revision 248307)
+++ libiberty/ChangeLog (working copy)
@@ -1,3 +1,7 @@ 
+2017-05-19  Eli Zaretskii <eliz@gnu.org>
+
+       * configure.ac (*-*-mingw*): Don't build waitpid.c.
+
 2017-05-02  Iain Buclaw  <ibuclaw@gdcproject.org>
 
        * d-demangle.c (dlang_hexdigit): New function.
Index: libiberty/configure.ac
===================================================================
--- libiberty/configure.ac      (revision 248307)
+++ libiberty/configure.ac      (working copy)
@@ -493,7 +493,6 @@ 
     AC_LIBOBJ([strnlen])
     AC_LIBOBJ([strverscmp])
     AC_LIBOBJ([vasprintf])
-    AC_LIBOBJ([waitpid])
 
     for f in $funcs; do
       case "$f" in