| Message ID | 20101103043021.5321.73681.sendpatchset@localhost.localdomain |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> From: Amerigo Wang [amwang@redhat.com] > Sent: Wednesday, November 03, 2010 9:55 AM > To: linux-kernel@vger.kernel.org > Cc: Dhananjay Phadke; Amit Salecha; Narender Kumar; netdev@vger.kernel.org; David S. Miller; Amerigo Wang > Subject: [Patch] netxen: remove unused firmware exports > > Quote from Amit Salecha: > > "Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already > submitted and its present in linux-firmware.git. > > I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and > NX_P3_MN_ROMIMAGE_NAME. Whether this will be submitted ?" > > We have to remove these, otherwise we will get wrong info from modinfo. > > Signed-off-by: WANG Cong <amwang@redhat.com> > Cc: Amit Kumar Salecha <amit.salecha@qlogic.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Dhananjay Phadke <dhananjay.phadke@qlogic.com> > Cc: Narender Kumar narender.kumar@qlogic.com Acked-by: Amit Kumar Salecha <amit.salecha@qlogic.com>-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Amit Salecha <amit.salecha@qlogic.com> Date: Wed, 3 Nov 2010 04:35:01 -0500 >> From: Amerigo Wang [amwang@redhat.com] >> Sent: Wednesday, November 03, 2010 9:55 AM >> To: linux-kernel@vger.kernel.org >> Cc: Dhananjay Phadke; Amit Salecha; Narender Kumar; netdev@vger.kernel.org; David S. Miller; Amerigo Wang >> Subject: [Patch] netxen: remove unused firmware exports >> >> Quote from Amit Salecha: >> >> "Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already >> submitted and its present in linux-firmware.git. >> >> I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and >> NX_P3_MN_ROMIMAGE_NAME. Whether this will be submitted ?" >> >> We have to remove these, otherwise we will get wrong info from modinfo. >> >> Signed-off-by: WANG Cong <amwang@redhat.com> >> Cc: Amit Kumar Salecha <amit.salecha@qlogic.com> >> Cc: "David S. Miller" <davem@davemloft.net> >> Cc: Dhananjay Phadke <dhananjay.phadke@qlogic.com> >> Cc: Narender Kumar narender.kumar@qlogic.com > > Acked-by: Amit Kumar Salecha <amit.salecha@qlogic.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index 50820be..5ddf112 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/drivers/net/netxen/netxen_nic_main.c @@ -41,9 +41,6 @@ MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver"); MODULE_LICENSE("GPL"); MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID); -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME); -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME); -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME); MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME); char netxen_nic_driver_name[] = "netxen_nic";
Quote from Amit Salecha: "Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already submitted and its present in linux-firmware.git. I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and NX_P3_MN_ROMIMAGE_NAME. Whether this will be submitted ?" We have to remove these, otherwise we will get wrong info from modinfo. Signed-off-by: WANG Cong <amwang@redhat.com> Cc: Amit Kumar Salecha <amit.salecha@qlogic.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Dhananjay Phadke <dhananjay.phadke@qlogic.com> Cc: Narender Kumar <narender.kumar@qlogic.com> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html