diff mbox

[U-Boot,1/1] env: correct sign for error code

Message ID 20170508173058.16957-1-xypron.glpk@gmx.de
State Accepted
Commit 9b57e252ffb85b175b0818bf01fb20086d788f5d
Delegated to: Tom Rini
Headers show

Commit Message

Heinrich Schuchardt May 8, 2017, 5:30 p.m. UTC 
Error codes should be negative.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 common/env_attr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini May 12, 2017, 5:21 p.m. UTC | #1 
On Mon, May 08, 2017 at 07:30:58PM +0200, xypron.glpk@gmx.de wrote:

> Error codes should be negative.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/common/env_attr.c b/common/env_attr.c
index 5bfe5e3a89..386219087b 100644
--- a/common/env_attr.c
+++ b/common/env_attr.c
@@ -153,7 +153,7 @@  static int regex_callback(const char *name, const char *attributes, void *priv)
 		}
 	} else {
 		printf("Error compiling regex: %s\n", slre.err_str);
-		retval = EINVAL;
+		retval = -EINVAL;
 	}
 done:
 	return retval;