| Message ID | 20101028075631.GA7690@elte.hu |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Oct 28, 2010, at 3:56 AM, Ingo Molnar wrote: > > hi Ted, > >> Theodore Ts'o (18): >> ext4: rename {exit,init}_ext4_*() to ext4_{exit,init}_*() > > Today's -tip fails to build due to upstream commit 5dabfc7 ("ext4: rename > {exit,init}_ext4_*() to ext4_{exit,init}_*()"), on all[yes/mod]config with > CONFIG_EXT4_FS_XATTR disabled: > > fs/ext4/super.c:4776: error: implicit declaration of function ‘ext4_init_xattr’ > > Commit 5dabfc7 renamed init_ext4_xattr to ext4_init_xattr but forgot to update the > definition in fs/ext4/xattr.h. The patch below fixes it. Acked-by: "Theodore Ts'o" <tytso@mit.edu> Thanks for catching this, my bad. -- Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 28, 2010 at 12:56 AM, Ingo Molnar <mingo@elte.hu> wrote: > > Today's -tip fails to build due to upstream commit 5dabfc7 ("ext4: rename > {exit,init}_ext4_*() to ext4_{exit,init}_*()"), on all[yes/mod]config with > CONFIG_EXT4_FS_XATTR disabled: Btw, could you try to write these things so that the changelog doesn't have to be totally rewritten? Now I always end up having to move things around and edit them to be useful from a long-term perspective, which is kind of silly. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Thu, Oct 28, 2010 at 12:56 AM, Ingo Molnar <mingo@elte.hu> wrote: > > > > Today's -tip fails to build due to upstream commit 5dabfc7 ("ext4: rename > > {exit,init}_ext4_*() to ext4_{exit,init}_*()"), on all[yes/mod]config with > > CONFIG_EXT4_FS_XATTR disabled: > > Btw, could you try to write these things so that the changelog doesn't have to be > totally rewritten? Now I always end up having to move things around and edit them > to be useful from a long-term perspective, which is kind of silly. Heh, i was just lazy and used sfr's linux-next build bug reporting mails as a template ;-) Point taken in any case, i'll read your edited changelog and will change the template accordingly. Would this: Upstream commit 5dabfc7 ("ext4: rename {exit,init}_ext4_*() to ext4_{exit,init}_*()"), breaks the build on all[yes/mod]config with CONFIG_EXT4_FS_XATTR disabled: ... have been better? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Linus, if it's helpful, I have a pull request with correctly worded
changelogs here:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus
My apologies again for screwing up these configs. The following has
been tested with allnoconfig, and I'm currently in the process of
testing allyesconfig (which I'm fairly confident will compile, or at
least if it fails, it won't be due to changes that came in via my
tree).
- Ted
Ingo Molnar (2):
ext4: Fix build when !CONFIG_EXT4_FS_XATTR
fs: build fix when !CONFIG_BLOCK
fs/ext4/xattr.h | 2 +-
include/linux/fs.h | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 28, 2010 at 9:38 AM, Ingo Molnar <mingo@elte.hu> wrote: > > Point taken in any case, i'll read your edited changelog and will change the > template accordingly. > > Would this: > > Upstream commit 5dabfc7 ("ext4: rename {exit,init}_ext4_*() to > ext4_{exit,init}_*()"), breaks the build on all[yes/mod]config with > CONFIG_EXT4_FS_XATTR disabled: > > ... > > have been better? Yes. Except for the kernel the default git commit abbreviation is borderline too short. Seven hex-chars can easily alias with a few more pulls from me: git will not give aliases at the time it gives a shorthand, but a month or two later the abbreviated commit may no longer be unique. So I suggest using --abbrev=12 or similar. What I ended up writing your commit as was this: ext4: fix compile with CONFIG_EXT4_FS_XATTR disabled Commit 5dabfc78dced ("ext4: rename {exit,init}_ext4_*() to ext4_{exit,init}_*()") causes fs/ext4/super.c:4776: error: implicit declaration of function ‘ext4_init_xattr’ when CONFIG_EXT4_FS_XATTR is disabled. It renamed init_ext4_xattr to ext4_init_xattr but forgot to update the dummy definition in fs/ext4/xattr.h. Signed-off-by: Ingo Molnar <mingo@elte.hu> Acked-by: "Theodore Ts'o" <tytso@mit.edu> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> but that's just me. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Thu, Oct 28, 2010 at 9:38 AM, Ingo Molnar <mingo@elte.hu> wrote: > > > > Point taken in any case, i'll read your edited changelog and will change the > > template accordingly. > > > > Would this: > > > > Upstream commit 5dabfc7 ("ext4: rename {exit,init}_ext4_*() to > > ext4_{exit,init}_*()"), breaks the build on all[yes/mod]config with > > CONFIG_EXT4_FS_XATTR disabled: > > > > ... > > > > have been better? > > Yes. Except for the kernel the default git commit abbreviation is borderline too > short. Seven hex-chars can easily alias with a few more pulls from me: git will > not give aliases at the time it gives a shorthand, but a month or two later the > abbreviated commit may no longer be unique. > > So I suggest using --abbrev=12 or similar. ok. A helper script i use does this: git log --pretty=format:"%h: %s" $@ I have added --abbrev=12. Might make sense to lengthen the %h default in upstream Git as well? > What I ended up writing your commit as was this: > > ext4: fix compile with CONFIG_EXT4_FS_XATTR disabled > > Commit 5dabfc78dced ("ext4: rename {exit,init}_ext4_*() to > ext4_{exit,init}_*()") causes > > fs/ext4/super.c:4776: error: implicit declaration of function ‘ext4_init_xattr’ > > when CONFIG_EXT4_FS_XATTR is disabled. > > It renamed init_ext4_xattr to ext4_init_xattr but forgot to update the > dummy definition in fs/ext4/xattr.h. > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > Acked-by: "Theodore Ts'o" <tytso@mit.edu> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > > but that's just me. Ok, this indeed is much nicer to read. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux.orig/fs/ext4/xattr.h +++ linux/fs/ext4/xattr.h @@ -122,7 +122,7 @@ ext4_xattr_put_super(struct super_block } static __init inline int -init_ext4_xattr(void) +ext4_init_xattr(void) { return 0; }