diff mbox

[RFC,1/2] configs: raspberrypi3: fix mismatch cpu arch

Message ID 20170416151409.7665-2-gael.portay@savoirfairelinux.com
State Superseded
Headers show

Commit Message

Gaël PORTAY April 16, 2017, 3:14 p.m. UTC
The raspberrypi3 is powered by a Broadcom BCM2837 which is a Cortex-A53.

Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>
---
 configs/raspberrypi3_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnout Vandecappelle April 18, 2017, 8:15 p.m. UTC | #1
On 16-04-17 17:14, Gaël PORTAY wrote:
> The raspberrypi3 is powered by a Broadcom BCM2837 which is a Cortex-A53.
> 
> Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Just to be sure: have you boot-tested the new defconfig?

 Regards,
 Arnout

> ---
>  configs/raspberrypi3_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
> index 1b2134e0b..3d8949765 100644
> --- a/configs/raspberrypi3_defconfig
> +++ b/configs/raspberrypi3_defconfig
> @@ -1,5 +1,5 @@
>  BR2_arm=y
> -BR2_cortex_a7=y
> +BR2_cortex_a53=y
>  BR2_ARM_EABIHF=y
>  BR2_ARM_FPU_NEON_VFPV4=y
>  
>
Gaël PORTAY April 18, 2017, 8:52 p.m. UTC | #2
Arnout,

On Tue, Apr 18, 2017 at 10:15:30PM +0200, Arnout Vandecappelle wrote:
> 
> On 16-04-17 17:14, Gaël PORTAY wrote:
> > The raspberrypi3 is powered by a Broadcom BCM2837 which is a Cortex-A53.
> > 
> > Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>
> 
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> 
>  Just to be sure: have you boot-tested the new defconfig?
> 

Yes, I have tested this new configuration.

As you can see in the second patch, this new configuration has broken the
compilation of qtbase.

>  Regards,
>  Arnout
> 

Regards,
Gaël
Ricardo Martincoski April 19, 2017, 5:43 p.m. UTC | #3
Gaël,

On Sun, Apr 16, 2017 at 12:14 PM, Gaël PORTAY wrote:

> The raspberrypi3 is powered by a Broadcom BCM2837 which is a Cortex-A53.
> 
> Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>

Tested-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
[boot-tested: I can login using the HDMI console]

Regards,
Ricardo
Thomas Petazzoni May 2, 2017, 8:40 p.m. UTC | #4
Hello,

On Sun, 16 Apr 2017 11:14:08 -0400, Gaël PORTAY wrote:
> The raspberrypi3 is powered by a Broadcom BCM2837 which is a Cortex-A53.
> 
> Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>
> ---
>  configs/raspberrypi3_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, I have applied https://patchwork.ozlabs.org/patch/757022/
instead, which was a little bit more complete, but essentially does the
same thing.

Thanks!

Thomas
diff mbox

Patch

diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
index 1b2134e0b..3d8949765 100644
--- a/configs/raspberrypi3_defconfig
+++ b/configs/raspberrypi3_defconfig
@@ -1,5 +1,5 @@ 
 BR2_arm=y
-BR2_cortex_a7=y
+BR2_cortex_a53=y
 BR2_ARM_EABIHF=y
 BR2_ARM_FPU_NEON_VFPV4=y