| Message ID | 20170421070230.16582-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
> -----Original Message----- > From: Colin King [mailto:colin.king@canonical.com] > Sent: Friday, April 21, 2017 3:03 PM > To: Richard Zhu <hongxing.zhu@nxp.com>; Lucas Stach > <l.stach@pengutronix.de>; Bjorn Helgaas <bhelgaas@google.com>; linux- > pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Subject: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control" > > From: Colin Ian King <colin.king@canonical.com> > > trivial fix to spelling mistake in dev_err message > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Richard Zhu <hongxing.Zhu@nxp.com> Best Regards hongxing zhu Email: hongxing.zhu@nxp.com > --- > drivers/pci/dwc/pci-imx6.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c index > 102edcf1e261..129717ae5022 100644 > --- a/drivers/pci/dwc/pci-imx6.c > +++ b/drivers/pci/dwc/pci-imx6.c > @@ -726,13 +726,13 @@ static int imx6_pcie_probe(struct platform_device > *pdev) > imx6_pcie->pciephy_reset = devm_reset_control_get(dev, > "pciephy"); > if (IS_ERR(imx6_pcie->pciephy_reset)) { > - dev_err(dev, "Failed to get PCIEPHY reset contol\n"); > + dev_err(dev, "Failed to get PCIEPHY reset control\n"); > return PTR_ERR(imx6_pcie->pciephy_reset); > } > > imx6_pcie->apps_reset = devm_reset_control_get(dev, > "apps"); > if (IS_ERR(imx6_pcie->apps_reset)) { > - dev_err(dev, "Failed to get PCIE APPS reset > contol\n"); > + dev_err(dev, "Failed to get PCIE APPS reset > control\n"); > return PTR_ERR(imx6_pcie->apps_reset); > } > break; > -- > 2.11.0
On Fri, Apr 21, 2017 at 08:02:30AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > trivial fix to spelling mistake in dev_err message > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied with Richard's ack to pci/host-imx6 for v4.12, thanks. FWIW, there are about 25 other occurrences of "contol" in other parts of the tree. > --- > drivers/pci/dwc/pci-imx6.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c > index 102edcf1e261..129717ae5022 100644 > --- a/drivers/pci/dwc/pci-imx6.c > +++ b/drivers/pci/dwc/pci-imx6.c > @@ -726,13 +726,13 @@ static int imx6_pcie_probe(struct platform_device *pdev) > imx6_pcie->pciephy_reset = devm_reset_control_get(dev, > "pciephy"); > if (IS_ERR(imx6_pcie->pciephy_reset)) { > - dev_err(dev, "Failed to get PCIEPHY reset contol\n"); > + dev_err(dev, "Failed to get PCIEPHY reset control\n"); > return PTR_ERR(imx6_pcie->pciephy_reset); > } > > imx6_pcie->apps_reset = devm_reset_control_get(dev, "apps"); > if (IS_ERR(imx6_pcie->apps_reset)) { > - dev_err(dev, "Failed to get PCIE APPS reset contol\n"); > + dev_err(dev, "Failed to get PCIE APPS reset control\n"); > return PTR_ERR(imx6_pcie->apps_reset); > } > break; > -- > 2.11.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, 2017-04-25 at 14:04 -0500, Bjorn Helgaas wrote: > On Fri, Apr 21, 2017 at 08:02:30AM +0100, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > trivial fix to spelling mistake in dev_err message > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Applied with Richard's ack to pci/host-imx6 for v4.12, thanks. > > FWIW, there are about 25 other occurrences of "contol" in other parts > of the tree. Colin seems to focus on the logging format strings and not code comments. Other than these 2, there are 28 other instances in -next. All of them are not output anywhere, these are just source code comments. $ git grep -w -i -E "contoller|contol" | wc -l 30
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c index 102edcf1e261..129717ae5022 100644 --- a/drivers/pci/dwc/pci-imx6.c +++ b/drivers/pci/dwc/pci-imx6.c @@ -726,13 +726,13 @@ static int imx6_pcie_probe(struct platform_device *pdev) imx6_pcie->pciephy_reset = devm_reset_control_get(dev, "pciephy"); if (IS_ERR(imx6_pcie->pciephy_reset)) { - dev_err(dev, "Failed to get PCIEPHY reset contol\n"); + dev_err(dev, "Failed to get PCIEPHY reset control\n"); return PTR_ERR(imx6_pcie->pciephy_reset); } imx6_pcie->apps_reset = devm_reset_control_get(dev, "apps"); if (IS_ERR(imx6_pcie->apps_reset)) { - dev_err(dev, "Failed to get PCIE APPS reset contol\n"); + dev_err(dev, "Failed to get PCIE APPS reset control\n"); return PTR_ERR(imx6_pcie->apps_reset); } break;