mbox

Xenial SRU - UbuntuKVM guest crashed while running I/O stress test with Ubuntu kernel 4.4.0-47-generic

Message ID e8893868-61d1-3e83-22a2-80fc92d1a76e@canonical.com
State New
Headers show

Pull-request

git://kernel.ubuntu.com/rtg/ubuntu-xenial.git ppc64el-lp1659111

Message

Tim Gardner April 7, 2017, 2:37 p.m. UTC 
https://bugs.launchpad.net/bugs/1659111

See attached.

Though this looks like a big scary patch set, the 2 big prerequisite
backports are largely mechanical changes with no functional changes.
Subsequent patches are clean cherry-picks and righteous bug fixes (or
minor backports). I've run some stress-ng and ecryptfs stress tests
without any errors. I/O stress testing from IBM is also positive.

rtg

Comments

Seth Forshee April 10, 2017, 4:40 p.m. UTC | #1 
On Fri, Apr 07, 2017 at 03:37:46PM +0100, Tim Gardner wrote:
> https://bugs.launchpad.net/bugs/1659111
> 
> See attached.
> 
> Though this looks like a big scary patch set, the 2 big prerequisite
> backports are largely mechanical changes with no functional changes.
> Subsequent patches are clean cherry-picks and righteous bug fixes (or
> minor backports). I've run some stress-ng and ecryptfs stress tests
> without any errors. I/O stress testing from IBM is also positive.

It's difficult to really review some of those without knowing the code
better than I do. The backports do look correct though, and most of the
scarier changes are clean cherry picks. I did find a couple of minor
problems though.

It looks like you accidentally added a new file in your backport of
dc3b17cc8bf2 "block: Use pointer to backing_dev_info from
request_queue". It's a file that was touched in the upstream commit but
not present in 4.4.

It also looks like you need to s/cherry picked/backported/ for many of
the commits.

Seth
Brad Figg April 17, 2017, 2:46 p.m. UTC | #2
Thadeu Lima de Souza Cascardo April 25, 2017, 2:08 p.m. UTC | #3 
Applied to xenial master-next branch.

Thanks.
Cascardo.