| Message ID | 1492795881-11914-2-git-send-email-vyasevic@redhat.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 4/21/17 11:31 AM, Vladislav Yasevich wrote: > The data signaling name change is already provided at > the end of do_setlink(). This event handler just generates > a duplicate announcement. Disable it. > > CC: David Ahern <dsa@cumulusnetworks.com> > Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com> > --- > net/core/rtnetlink.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > index 0ee5479..e8e6816 100644 > --- a/net/core/rtnetlink.c > +++ b/net/core/rtnetlink.c > @@ -4123,7 +4123,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi > > switch (event) { > case NETDEV_REBOOT: > - case NETDEV_CHANGENAME: > case NETDEV_FEAT_CHANGE: > case NETDEV_BONDING_FAILOVER: > case NETDEV_NOTIFY_PEERS: > I only see one using the ip monitor. $ ip li set foobar name fubar generates these 3 messages: [LINK]12: fubar: <BROADCAST,NOARP> mtu 1500 qdisc noqueue state DOWN group default link/ether 76:cd:72:dd:2a:cb brd ff:ff:ff:ff:ff:ff Unknown message: type=0x00000051(81) flags=0x00000000(0)len=0x0000001c(28) [NETCONF]ipv4 dev dummy2 forwarding on rp_filter off mc_forwarding off proxy_neigh off ignore_routes_with_linkdown off Unknown message: type=0x00000051(81) flags=0x00000000(0)len=0x0000001c(28) [NETCONF]ipv6 dev dummy2 forwarding on mc_forwarding off proxy_neigh off ignore_routes_with_linkdown off do_setlink only sets DO_SETLINK_MODIFIED so a name change alone will not generate 2 messages.
On 04/21/2017 02:08 PM, David Ahern wrote: > On 4/21/17 11:31 AM, Vladislav Yasevich wrote: >> The data signaling name change is already provided at >> the end of do_setlink(). This event handler just generates >> a duplicate announcement. Disable it. >> >> CC: David Ahern <dsa@cumulusnetworks.com> >> Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com> >> --- >> net/core/rtnetlink.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >> index 0ee5479..e8e6816 100644 >> --- a/net/core/rtnetlink.c >> +++ b/net/core/rtnetlink.c >> @@ -4123,7 +4123,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi >> >> switch (event) { >> case NETDEV_REBOOT: >> - case NETDEV_CHANGENAME: >> case NETDEV_FEAT_CHANGE: >> case NETDEV_BONDING_FAILOVER: >> case NETDEV_NOTIFY_PEERS: >> > > > I only see one using the ip monitor. > > $ ip li set foobar name fubar > > generates these 3 messages: > > [LINK]12: fubar: <BROADCAST,NOARP> mtu 1500 qdisc noqueue state DOWN > group default > link/ether 76:cd:72:dd:2a:cb brd ff:ff:ff:ff:ff:ff > Unknown message: type=0x00000051(81) flags=0x00000000(0)len=0x0000001c(28) > [NETCONF]ipv4 dev dummy2 forwarding on rp_filter off mc_forwarding off > proxy_neigh off ignore_routes_with_linkdown off > Unknown message: type=0x00000051(81) flags=0x00000000(0)len=0x0000001c(28) > [NETCONF]ipv6 dev dummy2 forwarding on mc_forwarding off proxy_neigh off > ignore_routes_with_linkdown off > > do_setlink only sets DO_SETLINK_MODIFIED so a name change alone will not > generate 2 messages. > Actually, it has nothing to do with above flag. Setting DO_SETLINK_MODIFIED will still generate notifications, but only if the device is UP. However, it looks like link name change can only be done when the link is down. As a result, netdev_state_change will not report it, so we only see the 'event' one. So this is patch isn't needed, but only as a kind-of side-effect.. -vlad
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 0ee5479..e8e6816 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -4123,7 +4123,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi switch (event) { case NETDEV_REBOOT: - case NETDEV_CHANGENAME: case NETDEV_FEAT_CHANGE: case NETDEV_BONDING_FAILOVER: case NETDEV_NOTIFY_PEERS:
The data signaling name change is already provided at the end of do_setlink(). This event handler just generates a duplicate announcement. Disable it. CC: David Ahern <dsa@cumulusnetworks.com> Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com> --- net/core/rtnetlink.c | 1 - 1 file changed, 1 deletion(-)