| Message ID | 20170419095432.GA4266@mwanda |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> We've got the number of longs, yes, but we should multiply by > sizeof(long) to get the number of bytes needed. > > Fixes: e4917d46a653 ("qede: Add aRFS support") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thanks Dan. Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Wed, 19 Apr 2017 12:54:33 +0300 > We've got the number of longs, yes, but we should multiply by > sizeof(long) to get the number of bytes needed. > > Fixes: e4917d46a653 ("qede: Add aRFS support") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied, thanks.
diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c index 8c594a3ca63b..34473fbac798 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_filter.c +++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c @@ -267,7 +267,8 @@ int qede_alloc_arfs(struct qede_dev *edev) return -ENOMEM; } - edev->arfs->arfs_fltr_bmap = vzalloc(BITS_TO_LONGS(QEDE_RFS_MAX_FLTR)); + edev->arfs->arfs_fltr_bmap = vzalloc(BITS_TO_LONGS(QEDE_RFS_MAX_FLTR) * + sizeof(long)); if (!edev->arfs->arfs_fltr_bmap) { free_irq_cpu_rmap(edev->ndev->rx_cpu_rmap); edev->ndev->rx_cpu_rmap = NULL;
We've got the number of longs, yes, but we should multiply by sizeof(long) to get the number of bytes needed. Fixes: e4917d46a653 ("qede: Add aRFS support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Btw, this driver use vmalloc() all over the place but kmalloc() is more appropriate when you're allocating tiny ammounts.