| Message ID | 20170414214228.32521-1-zajec5@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Apr 14, 2017 at 5:42 PM, Rafał Miłecki <zajec5@gmail.com> wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > This uses CPU thermal sensor available on every Northstar chipset to > monitor temperature. We don't have any cooling or throttling so only a > critical trip was added. Haha! You beat me to it (as I had a similar patch queued). This looks good to me. Acked-by: Jon Mason <jon.mason@broadcom.com> > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > arch/arm/boot/dts/bcm5301x.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi > index 6a2afe7880ae..bbf39deb89f3 100644 > --- a/arch/arm/boot/dts/bcm5301x.dtsi > +++ b/arch/arm/boot/dts/bcm5301x.dtsi > @@ -356,6 +356,12 @@ > "sata2"; > }; > > + thermal: thermal@1800c2c0 { > + compatible = "brcm,ns-thermal"; > + reg = <0x1800c2c0 0x10>; > + #thermal-sensor-cells = <0>; > + }; > + > srab: srab@18007000 { > compatible = "brcm,bcm5301x-srab"; > reg = <0x18007000 0x1000>; > @@ -419,4 +425,24 @@ > status = "disabled"; > }; > }; > + > + thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay-passive = <0>; > + polling-delay = <1000>; > + coefficients = <(-556) 418000>; > + thermal-sensors = <&thermal>; > + > + trips { > + cpu-crit { > + temperature = <125000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + }; > + }; > + }; > }; > -- > 2.11.0 >
On 17 April 2017 at 16:54, Jon Mason <jon.mason@broadcom.com> wrote: > On Fri, Apr 14, 2017 at 5:42 PM, Rafał Miłecki <zajec5@gmail.com> wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> This uses CPU thermal sensor available on every Northstar chipset to >> monitor temperature. We don't have any cooling or throttling so only a >> critical trip was added. > > Haha! You beat me to it (as I had a similar patch queued). > > This looks good to me. > > Acked-by: Jon Mason <jon.mason@broadcom.com> :) Thanks I'd appreciate adding thermal to NSP DT. I don't have any NSP unit to try it on my own.
On Mon, Apr 17, 2017 at 12:14 PM, Rafał Miłecki <zajec5@gmail.com> wrote: > On 17 April 2017 at 16:54, Jon Mason <jon.mason@broadcom.com> wrote: >> On Fri, Apr 14, 2017 at 5:42 PM, Rafał Miłecki <zajec5@gmail.com> wrote: >>> From: Rafał Miłecki <rafal@milecki.pl> >>> >>> This uses CPU thermal sensor available on every Northstar chipset to >>> monitor temperature. We don't have any cooling or throttling so only a >>> critical trip was added. >> >> Haha! You beat me to it (as I had a similar patch queued). >> >> This looks good to me. >> >> Acked-by: Jon Mason <jon.mason@broadcom.com> > > :) Thanks > > I'd appreciate adding thermal to NSP DT. I don't have any NSP unit to > try it on my own. I'm doing so right now. I have it working, I just need to clean up the patches.
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi index 6a2afe7880ae..bbf39deb89f3 100644 --- a/arch/arm/boot/dts/bcm5301x.dtsi +++ b/arch/arm/boot/dts/bcm5301x.dtsi @@ -356,6 +356,12 @@ "sata2"; }; + thermal: thermal@1800c2c0 { + compatible = "brcm,ns-thermal"; + reg = <0x1800c2c0 0x10>; + #thermal-sensor-cells = <0>; + }; + srab: srab@18007000 { compatible = "brcm,bcm5301x-srab"; reg = <0x18007000 0x1000>; @@ -419,4 +425,24 @@ status = "disabled"; }; }; + + thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + coefficients = <(-556) 418000>; + thermal-sensors = <&thermal>; + + trips { + cpu-crit { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + + cooling-maps { + }; + }; + }; };