Message ID | AANLkTiniynJdbRegwzuAtXiOURWnkc4k97AFpMj4+E8X@mail.gmail.com |
---|---|
State | New |
Headers | show |
Hello Ian, * Ian Lance Taylor wrote on Mon, Oct 18, 2010 at 10:08:21PM CEST: > Ping for build maintainers. I cannot approve this but I think this can be considered as obvious. One question is why it didn't show up earlier. Cheers, Ralf > On Thu, Oct 7, 2010 at 4:54 PM, Ian Lance Taylor <iant@google.com> wrote: > > * Makefile.def (target_modules): Set lib_path to src/.libs for > > libstdc++-v3 module. > > * Makefile.tpl: Fix typo in TARGET_LIB_PATH comment. > > * Makefile.in: Rebuild. > --- Makefile.def (revision 165058) > +++ Makefile.def (working copy) > @@ -149,7 +149,7 @@ host_modules= { module= lto-plugin; boot > > target_modules = { module= libstdc++-v3; > bootstrap=true; > - lib_path=.libs; > + lib_path=src/.libs; > raw_cxx=true; }; > target_modules = { module= libmudflap; lib_path=.libs; }; > target_modules = { module= libssp; lib_path=.libs; };
On 10/20/2010 07:24 AM, Ralf Wildenhues wrote: > Hello Ian, > > * Ian Lance Taylor wrote on Mon, Oct 18, 2010 at 10:08:21PM CEST: >> Ping for build maintainers. > > I cannot approve this but I think this can be considered as obvious. Indeed. Paolo
Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes: > * Ian Lance Taylor wrote on Mon, Oct 18, 2010 at 10:08:21PM CEST: >> Ping for build maintainers. > > I cannot approve this but I think this can be considered as obvious. > One question is why it didn't show up earlier. Thanks. Committed. I think it didn't show up earlier simply because there are no gcc programs that are written in C++ and run during the build. The testsuite uses other mechanisms to set LD_LIBRARY_PATH. Ian
Index: Makefile.def =================================================================== --- Makefile.def (revision 165058) +++ Makefile.def (working copy) @@ -149,7 +149,7 @@ host_modules= { module= lto-plugin; boot target_modules = { module= libstdc++-v3; bootstrap=true; - lib_path=.libs; + lib_path=src/.libs; raw_cxx=true; }; target_modules = { module= libmudflap; lib_path=.libs; }; target_modules = { module= libssp; lib_path=.libs; }; Index: Makefile.tpl =================================================================== --- Makefile.tpl (revision 165058) +++ Makefile.tpl (working copy) @@ -513,7 +513,7 @@ all: ### # This is the list of directories that may be needed in RPATH_ENVVAR -# so that prorgams built for the target machine work. +# so that programs built for the target machine work. TARGET_LIB_PATH = [+ FOR target_modules +][+ IF lib_path +]$(TARGET_LIB_PATH_[+module+])[+ ENDIF lib_path +][+ ENDFOR target_modules +]$(HOST_LIB_PATH_gcc)