Message ID | 20170329183658.618942497@cogentembedded.com |
---|---|
State | New |
Headers | show |
Hello Sergei, > From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc- > owner@vger.kernel.org] On Behalf Of Sergei Shtylyov > Sent: 29 March 2017 19:37 > > The R8A7791 PFC driver was apparently based on the preliminary revisions of > the user's manual, which omitted the DVC_MUTE signal altogether in the > PFC section. The modern manual has the signal described, so just add the > necassary data to the driver... > > Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Should this patch also CC stable? (Patch 1/2 does) Kind regards, Chris > > --- > drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c > ========================================================== > ========= > --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c > +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c > @@ -203,7 +203,7 @@ enum { > > /* IPSR6 */ > FN_AUDIO_CLKB, FN_STP_OPWM_0_B, FN_MSIOF1_SCK_B, > - FN_SCIF_CLK, FN_BPFCLK_E, > + FN_SCIF_CLK, FN_DVC_MUTE, FN_BPFCLK_E, > FN_AUDIO_CLKC, FN_SCIFB0_SCK_C, FN_MSIOF1_SYNC_B, FN_RX2, > FN_SCIFA2_RXD, FN_FMIN_E, > FN_AUDIO_CLKOUT, FN_MSIOF1_SS1_B, FN_TX2, FN_SCIFA2_TXD, > @@ -573,7 +573,7 @@ enum { > > /* IPSR6 */ > AUDIO_CLKB_MARK, STP_OPWM_0_B_MARK, > MSIOF1_SCK_B_MARK, > - SCIF_CLK_MARK, BPFCLK_E_MARK, > + SCIF_CLK_MARK, DVC_MUTE_MARK, BPFCLK_E_MARK, > AUDIO_CLKC_MARK, SCIFB0_SCK_C_MARK, > MSIOF1_SYNC_B_MARK, RX2_MARK, > SCIFA2_RXD_MARK, FMIN_E_MARK, > AUDIO_CLKOUT_MARK, MSIOF1_SS1_B_MARK, TX2_MARK, > SCIFA2_TXD_MARK, @@ -1093,6 +1093,7 @@ static const u16 pinmux_data[] > = { > PINMUX_IPSR_MSEL(IP6_2_0, STP_OPWM_0_B, SEL_SSP_1), > PINMUX_IPSR_MSEL(IP6_2_0, MSIOF1_SCK_B, SEL_SOF1_1), > PINMUX_IPSR_MSEL(IP6_2_0, SCIF_CLK, SEL_SCIF_0), > + PINMUX_IPSR_GPSR (IP6_2_0, DVC_MUTE), > PINMUX_IPSR_MSEL(IP6_2_0, BPFCLK_E, SEL_FM_4), > PINMUX_IPSR_GPSR(IP6_5_3, AUDIO_CLKC), > PINMUX_IPSR_MSEL(IP6_5_3, SCIFB0_SCK_C, SEL_SCIFB_2), @@ - > 5899,7 +5900,7 @@ static const struct pinmux_cfg_reg pinmu > 0, 0, > /* IP6_2_0 [3] */ > FN_AUDIO_CLKB, FN_STP_OPWM_0_B, FN_MSIOF1_SCK_B, > - FN_SCIF_CLK, 0, FN_BPFCLK_E, > + FN_SCIF_CLK, FN_DVC_MUTE, FN_BPFCLK_E, > 0, 0, } > }, > { PINMUX_CFG_REG_VAR("IPSR7", 0xE606003C, 32, -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 30, 2017 at 9:33 AM, Chris Paterson <Chris.Paterson2@renesas.com> wrote: >> From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc- >> owner@vger.kernel.org] On Behalf Of Sergei Shtylyov >> Sent: 29 March 2017 19:37 >> >> The R8A7791 PFC driver was apparently based on the preliminary revisions of >> the user's manual, which omitted the DVC_MUTE signal altogether in the >> PFC section. The modern manual has the signal described, so just add the >> necassary data to the driver... >> >> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Should this patch also CC stable? (Patch 1/2 does) No need to spam stable with all these patches and reviews. If it has a Fixes-tag, the stable team will pick it up anyway. After it has ended up upstream. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 29, 2017 at 8:36 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > The R8A7791 PFC driver was apparently based on the preliminary revisions > of the user's manual, which omitted the DVC_MUTE signal altogether in > the PFC section. The modern manual has the signal described, so just add > the necassary data to the driver... > > Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Chris, On Thu, Mar 30, 2017 at 11:00 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Thu, Mar 30, 2017 at 9:33 AM, Chris Paterson > <Chris.Paterson2@renesas.com> wrote: >>> From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc- >>> owner@vger.kernel.org] On Behalf Of Sergei Shtylyov >>> Sent: 29 March 2017 19:37 >>> >>> The R8A7791 PFC driver was apparently based on the preliminary revisions of >>> the user's manual, which omitted the DVC_MUTE signal altogether in the >>> PFC section. The modern manual has the signal described, so just add the >>> necassary data to the driver... >>> >>> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> Should this patch also CC stable? (Patch 1/2 does) > > No need to spam stable with all these patches and reviews. > If it has a Fixes-tag, the stable team will pick it up anyway. After > it has ended > up upstream. And in this case, there's not really a need to backport it to stable, as there cannot be any users due to lack of pins using these definitions. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
SGVsbG8gR2VlcnQsDQoNCj4gRnJvbTogZ2VlcnQudXl0dGVyaG9ldmVuQGdtYWlsLmNvbQ0KPiBb bWFpbHRvOmdlZXJ0LnV5dHRlcmhvZXZlbkBnbWFpbC5jb21dIE9uIEJlaGFsZiBPZiBHZWVydCBV eXR0ZXJob2V2ZW4NCj4gU2VudDogMzAgTWFyY2ggMjAxNyAxMDoxMQ0KPiANCj4gSGkgQ2hyaXMs DQo+IA0KPiBPbiBUaHUsIE1hciAzMCwgMjAxNyBhdCAxMTowMCBBTSwgR2VlcnQgVXl0dGVyaG9l dmVuIDxnZWVydEBsaW51eC0NCj4gbTY4ay5vcmc+IHdyb3RlOg0KPiA+IE9uIFRodSwgTWFyIDMw LCAyMDE3IGF0IDk6MzMgQU0sIENocmlzIFBhdGVyc29uDQo+ID4gPENocmlzLlBhdGVyc29uMkBy ZW5lc2FzLmNvbT4gd3JvdGU6DQo+ID4+PiBGcm9tOiBsaW51eC1yZW5lc2FzLXNvYy1vd25lckB2 Z2VyLmtlcm5lbC5vcmcNCj4gPj4+IFttYWlsdG86bGludXgtcmVuZXNhcy1zb2MtIG93bmVyQHZn ZXIua2VybmVsLm9yZ10gT24gQmVoYWxmIE9mDQo+ID4+PiBTZXJnZWkgU2h0eWx5b3YNCj4gPj4+ IFNlbnQ6IDI5IE1hcmNoIDIwMTcgMTk6MzcNCj4gPj4+DQo+ID4+PiBUaGUgUjhBNzc5MSBQRkMg ZHJpdmVyICB3YXMgYXBwYXJlbnRseSBiYXNlZCBvbiB0aGUgcHJlbGltaW5hcnkNCj4gPj4+IHJl dmlzaW9ucyBvZiB0aGUgdXNlcidzICBtYW51YWwsIHdoaWNoICBvbWl0dGVkIHRoZSBEVkNfTVVU RSBzaWduYWwNCj4gPj4+IGFsdG9nZXRoZXIgaW4gdGhlIFBGQyBzZWN0aW9uLiBUaGUgbW9kZXJu IG1hbnVhbCBoYXMgdGhlIHNpZ25hbA0KPiA+Pj4gZGVzY3JpYmVkLCAgc28ganVzdCBhZGQgdGhl IG5lY2Fzc2FyeSBkYXRhIHRvIHRoZSBkcml2ZXIuLi4NCj4gPj4+DQo+ID4+PiBGaXhlczogNTA4 ODQ1MTk2MjM4ICgicGluY3RybDogc2gtcGZjOiByOGE3NzkxIFBGQyBzdXBwb3J0IikNCj4gPj4+ IFNpZ25lZC1vZmYtYnk6IFNlcmdlaSBTaHR5bHlvdiA8c2VyZ2VpLnNodHlseW92QGNvZ2VudGVt YmVkZGVkLmNvbT4NCj4gPj4NCj4gPj4gU2hvdWxkIHRoaXMgcGF0Y2ggYWxzbyBDQyBzdGFibGU/ IChQYXRjaCAxLzIgZG9lcykNCj4gPg0KPiA+IE5vIG5lZWQgdG8gc3BhbSBzdGFibGUgd2l0aCBh bGwgdGhlc2UgcGF0Y2hlcyBhbmQgcmV2aWV3cy4NCj4gPiBJZiBpdCBoYXMgYSBGaXhlcy10YWcs IHRoZSBzdGFibGUgdGVhbSB3aWxsIHBpY2sgaXQgdXAgYW55d2F5LiBBZnRlcg0KPiA+IGl0IGhh cyBlbmRlZCB1cCB1cHN0cmVhbS4NCg0KT2theS4NCg0KPiANCj4gQW5kIGluIHRoaXMgY2FzZSwg dGhlcmUncyBub3QgcmVhbGx5IGEgbmVlZCB0byBiYWNrcG9ydCBpdCB0byBzdGFibGUsIGFzIHRo ZXJlDQo+IGNhbm5vdCBiZSBhbnkgdXNlcnMgZHVlIHRvIGxhY2sgb2YgcGlucyB1c2luZyB0aGVz ZSBkZWZpbml0aW9ucy4NCg0KV2hlcmVhcyB0aGUgZmlyc3QgcGF0Y2ggaW4gdGhlIHNlcmllcyBm aXhlcyBhIHByb2JsZW0gdGhhdCAqaXMqIGN1cnJlbnRseSBzZWVuIGJ5IHVzZXJzLCBzbyB3aWxs IG5lZWQgYmFja3BvcnRpbmcuIE1ha2VzIHNlbnNlIG5vdywgdGhhbmtzIQ0KDQpLaW5kIHJlZ2Fy ZHMsIENocmlzDQoNCj4gDQo+IEdye29ldGplLGVldGluZ31zLA0KPiANCj4gICAgICAgICAgICAg ICAgICAgICAgICAgR2VlcnQNCj4gDQo+IC0tDQo+IEdlZXJ0IFV5dHRlcmhvZXZlbiAtLSBUaGVy ZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgtDQo+IG02OGsub3Jn DQo+IA0KPiBJbiBwZXJzb25hbCBjb252ZXJzYXRpb25zIHdpdGggdGVjaG5pY2FsIHBlb3BsZSwg SSBjYWxsIG15c2VsZiBhIGhhY2tlci4gQnV0DQo+IHdoZW4gSSdtIHRhbGtpbmcgdG8gam91cm5h bGlzdHMgSSBqdXN0IHNheSAicHJvZ3JhbW1lciIgb3Igc29tZXRoaW5nIGxpa2UgdGhhdC4NCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBMaW51cyBUb3J2YWxkcw0K -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello! On 3/30/2017 12:16 PM, Chris Paterson wrote: >>>>> From: linux-renesas-soc-owner@vger.kernel.org >>>>> [mailto:linux-renesas-soc- owner@vger.kernel.org] On Behalf Of >>>>> Sergei Shtylyov >>>>> Sent: 29 March 2017 19:37 >>>>> >>>>> The R8A7791 PFC driver was apparently based on the preliminary >>>>> revisions of the user's manual, which omitted the DVC_MUTE signal >>>>> altogether in the PFC section. The modern manual has the signal >>>>> described, so just add the necassary data to the driver... >>>>> >>>>> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") >>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> >>>> Should this patch also CC stable? (Patch 1/2 does) >>> >>> No need to spam stable with all these patches and reviews. >>> If it has a Fixes-tag, the stable team will pick it up anyway. After >>> it has ended up upstream. > > Okay. > >> >> And in this case, there's not really a need to backport it to stable, as there >> cannot be any users due to lack of pins using these definitions. > > Whereas the first patch in the series fixes a problem that *is* currently seen by users, so will need backporting. Makes sense now, thanks! Note that it might only be seen by some out-of-tree boards, as neither upstream supported R8A7791-based board enables HSCIF1... > Kind regards, Chris > >> >> Gr{oetje,eeting}s, >> >> Geert MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c =================================================================== --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c @@ -203,7 +203,7 @@ enum { /* IPSR6 */ FN_AUDIO_CLKB, FN_STP_OPWM_0_B, FN_MSIOF1_SCK_B, - FN_SCIF_CLK, FN_BPFCLK_E, + FN_SCIF_CLK, FN_DVC_MUTE, FN_BPFCLK_E, FN_AUDIO_CLKC, FN_SCIFB0_SCK_C, FN_MSIOF1_SYNC_B, FN_RX2, FN_SCIFA2_RXD, FN_FMIN_E, FN_AUDIO_CLKOUT, FN_MSIOF1_SS1_B, FN_TX2, FN_SCIFA2_TXD, @@ -573,7 +573,7 @@ enum { /* IPSR6 */ AUDIO_CLKB_MARK, STP_OPWM_0_B_MARK, MSIOF1_SCK_B_MARK, - SCIF_CLK_MARK, BPFCLK_E_MARK, + SCIF_CLK_MARK, DVC_MUTE_MARK, BPFCLK_E_MARK, AUDIO_CLKC_MARK, SCIFB0_SCK_C_MARK, MSIOF1_SYNC_B_MARK, RX2_MARK, SCIFA2_RXD_MARK, FMIN_E_MARK, AUDIO_CLKOUT_MARK, MSIOF1_SS1_B_MARK, TX2_MARK, SCIFA2_TXD_MARK, @@ -1093,6 +1093,7 @@ static const u16 pinmux_data[] = { PINMUX_IPSR_MSEL(IP6_2_0, STP_OPWM_0_B, SEL_SSP_1), PINMUX_IPSR_MSEL(IP6_2_0, MSIOF1_SCK_B, SEL_SOF1_1), PINMUX_IPSR_MSEL(IP6_2_0, SCIF_CLK, SEL_SCIF_0), + PINMUX_IPSR_GPSR(IP6_2_0, DVC_MUTE), PINMUX_IPSR_MSEL(IP6_2_0, BPFCLK_E, SEL_FM_4), PINMUX_IPSR_GPSR(IP6_5_3, AUDIO_CLKC), PINMUX_IPSR_MSEL(IP6_5_3, SCIFB0_SCK_C, SEL_SCIFB_2), @@ -5899,7 +5900,7 @@ static const struct pinmux_cfg_reg pinmu 0, 0, /* IP6_2_0 [3] */ FN_AUDIO_CLKB, FN_STP_OPWM_0_B, FN_MSIOF1_SCK_B, - FN_SCIF_CLK, 0, FN_BPFCLK_E, + FN_SCIF_CLK, FN_DVC_MUTE, FN_BPFCLK_E, 0, 0, } }, { PINMUX_CFG_REG_VAR("IPSR7", 0xE606003C, 32,
The R8A7791 PFC driver was apparently based on the preliminary revisions of the user's manual, which omitted the DVC_MUTE signal altogether in the PFC section. The modern manual has the signal described, so just add the necassary data to the driver... Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html