| Message ID | 20170328051226.21677-4-brendanhiggins@google.com |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: > Added device tree binding documentation for Aspeed I2C busses. > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > + i2c0: i2c-bus@40 { > + #address-cells = <1>; > + #size-cells = <0>; > + #interrupt-cells = <1>; > + reg = <0x40 0x40>; > + compatible = "aspeed,ast2400-i2c-bus"; > + bus = <0>; > + clocks = <&clk_apb>; > + clock-frequency = <100000>; For busses it's more traditional to make this "bus-frequency" but that's a nit and Linux/fdt has not respected that tradition terribly well. If you respin, it might be work changing. The clock-frequency tends to be the frequency of the controller itself. > + status = "disabled"; > + interrupts = <0>; > + interrupt-parent = <&i2c_ic>; > + }; > +};
>> + bus = <0>; >> + clocks = <&clk_apb>; >> + clock-frequency = <100000>; > > For busses it's more traditional to make this "bus-frequency" but > that's a nit and Linux/fdt has not respected that tradition terribly > well. If you respin, it might be work changing. > > The clock-frequency tends to be the frequency of the controller itself. Ah, okay. I will change this on the next revision.
On Tue, Mar 28, 2017 at 07:54:43PM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: > > Added device tree binding documentation for Aspeed I2C busses. > > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > > + i2c0: i2c-bus@40 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #interrupt-cells = <1>; > > + reg = <0x40 0x40>; > > + compatible = "aspeed,ast2400-i2c-bus"; > > + bus = <0>; > > + clocks = <&clk_apb>; > > + clock-frequency = <100000>; > > For busses it's more traditional to make this "bus-frequency" but > that's a nit and Linux/fdt has not respected that tradition terribly > well. If you respin, it might be work changing. Makes sense, but that's news to me. I'm still new to this DT stuff. > The clock-frequency tends to be the frequency of the controller itself. The clock binding has largely replaced that. Rob
On Mon, Mar 27, 2017 at 10:12:24PM -0700, Brendan Higgins wrote: > Added device tree binding documentation for Aspeed I2C busses. > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > --- > Changes for v2: > - None > Changes for v3: > - Removed reference to "bus" device tree param > Changes for v4: > - None > Changes for v5: > - None > Changes for v6: > - Replaced the controller property with and interrupt controller, leaving only > the busses in the I2C documentation. > --- > .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 ++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > new file mode 100644 > index 000000000000..fbcc501706b1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > @@ -0,0 +1,49 @@ > +Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs. > + > +Required Properties: > +- #address-cells : should be 1 > +- #size-cells : should be 0 > +- reg : address offset and range of bus > +- compatible : should be "aspeed,ast2400-i2c-bus" > + or "aspeed,ast2500-i2c-bus" > +- clocks : root clock of bus, should reference the APB > + clock > +- interrupts : interrupt number > +- interrupt-parent : interrupt controller for bus, should reference a > + aspeed,ast2400-i2c-ic or aspeed,ast2500-i2c-ic > + interrupt controller > + > +Optional Properties: > +- clock-frequency : frequency of the bus clock in Hz > + defaults to 100 kHz when not specified > + > +Example: > + > +i2c { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x1e78a000 0x1000>; > + > + i2c_ic: interrupt-controller@0 { > + #interrupt-cells = <1>; > + compatible = "aspeed,ast2400-i2c-ic"; > + reg = <0x0 0x40>; > + interrupts = <12>; > + interrupt-controller; > + }; > + > + i2c0: i2c-bus@40 { > + #address-cells = <1>; > + #size-cells = <0>; > + #interrupt-cells = <1>; > + reg = <0x40 0x40>; > + compatible = "aspeed,ast2400-i2c-bus"; > + bus = <0>; Not documented and what's it for? > + clocks = <&clk_apb>; > + clock-frequency = <100000>; > + status = "disabled"; Drop status from examples. > + interrupts = <0>; > + interrupt-parent = <&i2c_ic>; > + }; > +}; > -- > 2.12.2.564.g063fe858b8-goog >
diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt new file mode 100644 index 000000000000..fbcc501706b1 --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt @@ -0,0 +1,49 @@ +Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs. + +Required Properties: +- #address-cells : should be 1 +- #size-cells : should be 0 +- reg : address offset and range of bus +- compatible : should be "aspeed,ast2400-i2c-bus" + or "aspeed,ast2500-i2c-bus" +- clocks : root clock of bus, should reference the APB + clock +- interrupts : interrupt number +- interrupt-parent : interrupt controller for bus, should reference a + aspeed,ast2400-i2c-ic or aspeed,ast2500-i2c-ic + interrupt controller + +Optional Properties: +- clock-frequency : frequency of the bus clock in Hz + defaults to 100 kHz when not specified + +Example: + +i2c { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x1e78a000 0x1000>; + + i2c_ic: interrupt-controller@0 { + #interrupt-cells = <1>; + compatible = "aspeed,ast2400-i2c-ic"; + reg = <0x0 0x40>; + interrupts = <12>; + interrupt-controller; + }; + + i2c0: i2c-bus@40 { + #address-cells = <1>; + #size-cells = <0>; + #interrupt-cells = <1>; + reg = <0x40 0x40>; + compatible = "aspeed,ast2400-i2c-bus"; + bus = <0>; + clocks = <&clk_apb>; + clock-frequency = <100000>; + status = "disabled"; + interrupts = <0>; + interrupt-parent = <&i2c_ic>; + }; +};
Added device tree binding documentation for Aspeed I2C busses. Signed-off-by: Brendan Higgins <brendanhiggins@google.com> --- Changes for v2: - None Changes for v3: - Removed reference to "bus" device tree param Changes for v4: - None Changes for v5: - None Changes for v6: - Replaced the controller property with and interrupt controller, leaving only the busses in the I2C documentation. --- .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt