| Message ID | 1287103733-7121-1-git-send-email-nacc@us.ibm.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 01cf6fe8553b0ac649f3323d8da69b51cad8c468 |
| Delegated to: | Benjamin Herrenschmidt |
| Headers | show |
On 14 October 2010 19:48, Nishanth Aravamudan <nacc@us.ibm.com> wrote: > eeh and pci_dlpar #undef DEBUG, but I think they were added before the > ability to control this from Kconfig. It's really annoying to only get > some of the debug messages from these files. Leave the lpar.c #undef > alone as it produces so much output as to make the kernel unusable. > Update the Kconfig text to indicate this particular quirk :) > > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> OK, ignore my last email. Acked by: Linas Vepstas <linasvepstas@gmail.com> > --- a/arch/powerpc/platforms/pseries/Kconfig > +++ b/arch/powerpc/platforms/pseries/Kconfig > @@ -47,6 +47,12 @@ config LPARCFG > config PPC_PSERIES_DEBUG > depends on PPC_PSERIES && PPC_EARLY_DEBUG > bool "Enable extra debug logging in platforms/pseries" > + help > + Say Y here if you want the pseries core to produce a bunch of > + debug messages to the system log. Select this if you are having a > + problem with the pseries core and want to see more of what is > + going on. This does not enable debugging in lpar.c, which must > + be manually done due to its verbosity. > default y Umm, I see "default y" and you are not changing this but ... default y ?? Really? Also, I am guessing that the lpar spam is due only to a handful of printk's, while most of the rest will be infrequent. Just knock out the high-frequency ones... --linas
On Thu, 2010-10-14 at 20:54 -0500, Linas Vepstas wrote: > On 14 October 2010 19:48, Nishanth Aravamudan <nacc@us.ibm.com> wrote: > > eeh and pci_dlpar #undef DEBUG, but I think they were added before the > > ability to control this from Kconfig. It's really annoying to only get > > some of the debug messages from these files. Leave the lpar.c #undef > > alone as it produces so much output as to make the kernel unusable. > > Update the Kconfig text to indicate this particular quirk :) > > > > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> > > OK, ignore my last email. > > Acked by: Linas Vepstas <linasvepstas@gmail.com> I guess I'll ack it too seeing I added PPC_PSERIES_DEBUG: Acked-by: Michael Ellerman <michael@ellerman.id.au> > > --- a/arch/powerpc/platforms/pseries/Kconfig > > +++ b/arch/powerpc/platforms/pseries/Kconfig > > @@ -47,6 +47,12 @@ config LPARCFG > > config PPC_PSERIES_DEBUG > > depends on PPC_PSERIES && PPC_EARLY_DEBUG > > bool "Enable extra debug logging in platforms/pseries" > > + help > > + Say Y here if you want the pseries core to produce a bunch of > > + debug messages to the system log. Select this if you are having a > > + problem with the pseries core and want to see more of what is > > + going on. This does not enable debugging in lpar.c, which must > > + be manually done due to its verbosity. > > default y > > Umm, I see "default y" and you are not changing this but ... default y > ?? Really? Yes, default y if early debug is enabled. Unlike DEBUG_KERNEL, PPC_EARLY_DEBUG is a pretty good indication that you are doing some kernel development - because you have to choose exactly which platform you're working on. > Also, I am guessing that the lpar spam is due only to a handful of printk's, > while most of the rest will be infrequent. Just knock out the > high-frequency ones... No they're all related to the HPTE code, so you basically don't want any of them enabled unless you're debugging that, and most people aren't. cheers
diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index c667f0f..3139814 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig @@ -47,6 +47,12 @@ config LPARCFG config PPC_PSERIES_DEBUG depends on PPC_PSERIES && PPC_EARLY_DEBUG bool "Enable extra debug logging in platforms/pseries" + help + Say Y here if you want the pseries core to produce a bunch of + debug messages to the system log. Select this if you are having a + problem with the pseries core and want to see more of what is + going on. This does not enable debugging in lpar.c, which must + be manually done due to its verbosity. default y config PPC_SMLPAR diff --git a/arch/powerpc/platforms/pseries/eeh.c b/arch/powerpc/platforms/pseries/eeh.c index 34b7dc1..17a11c8 100644 --- a/arch/powerpc/platforms/pseries/eeh.c +++ b/arch/powerpc/platforms/pseries/eeh.c @@ -21,8 +21,6 @@ * Please address comments and feedback to Linas Vepstas <linas@austin.ibm.com> */ -#undef DEBUG - #include <linux/delay.h> #include <linux/init.h> #include <linux/list.h> diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c b/arch/powerpc/platforms/pseries/pci_dlpar.c index 4b7a062..5fcc92a 100644 --- a/arch/powerpc/platforms/pseries/pci_dlpar.c +++ b/arch/powerpc/platforms/pseries/pci_dlpar.c @@ -25,8 +25,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -#undef DEBUG - #include <linux/pci.h> #include <asm/pci-bridge.h> #include <asm/ppc-pci.h>
eeh and pci_dlpar #undef DEBUG, but I think they were added before the ability to control this from Kconfig. It's really annoying to only get some of the debug messages from these files. Leave the lpar.c #undef alone as it produces so much output as to make the kernel unusable. Update the Kconfig text to indicate this particular quirk :) Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> --- arch/powerpc/platforms/pseries/Kconfig | 6 ++++++ arch/powerpc/platforms/pseries/eeh.c | 2 -- arch/powerpc/platforms/pseries/pci_dlpar.c | 2 -- 3 files changed, 6 insertions(+), 4 deletions(-)