| Message ID | 1489729898-774-4-git-send-email-chunyan.zhang@spreadtrum.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, Mar 17, 2017 at 01:51:37PM +0800, Chunyan Zhang wrote: > SC9860 use the same serial device which SC9836 uses, so added a new > compatible string to support SC9860 as well, also added an example > of how to describe this serial device in DT. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > --- > Documentation/devicetree/bindings/serial/sprd-uart.txt | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt > index 2aff0f2..1db5d6f 100644 > --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt > @@ -1,7 +1,19 @@ > * Spreadtrum serial UART > > Required properties: > -- compatible: must be "sprd,sc9836-uart" > +- compatible: must be one of: > + * "sprd,sc9836-uart" > + * "sprd,sc9860-uart", "sprd,sc9836-uart" > + > - reg: offset and length of the register set for the device > - interrupts: exactly one interrupt specifier > - clocks: phandles to input clocks. > + > +Example: > + uart0: serial@000000 { serial@0 With that, Acked-by: Rob Herring <robh@kernel.org> > + compatible = "sprd,sc9860-uart", > + "sprd,sc9836-uart"; > + reg = <0x000000 0x100>; > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + }; > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, On 24 March 2017 at 10:36, Rob Herring <robh@kernel.org> wrote: > On Fri, Mar 17, 2017 at 01:51:37PM +0800, Chunyan Zhang wrote: >> SC9860 use the same serial device which SC9836 uses, so added a new >> compatible string to support SC9860 as well, also added an example >> of how to describe this serial device in DT. >> >> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> >> --- >> Documentation/devicetree/bindings/serial/sprd-uart.txt | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt >> index 2aff0f2..1db5d6f 100644 >> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt >> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt >> @@ -1,7 +1,19 @@ >> * Spreadtrum serial UART >> >> Required properties: >> -- compatible: must be "sprd,sc9836-uart" >> +- compatible: must be one of: >> + * "sprd,sc9836-uart" >> + * "sprd,sc9860-uart", "sprd,sc9836-uart" >> + >> - reg: offset and length of the register set for the device >> - interrupts: exactly one interrupt specifier >> - clocks: phandles to input clocks. >> + >> +Example: >> + uart0: serial@000000 { > > serial@0 > Addressed this. > With that, > > Acked-by: Rob Herring <robh@kernel.org> Thanks for your review, Chunyan > > >> + compatible = "sprd,sc9860-uart", >> + "sprd,sc9836-uart"; >> + reg = <0x000000 0x100>; >> + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ext_26m>; >> + }; >> -- >> 2.7.4 >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt index 2aff0f2..1db5d6f 100644 --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt @@ -1,7 +1,19 @@ * Spreadtrum serial UART Required properties: -- compatible: must be "sprd,sc9836-uart" +- compatible: must be one of: + * "sprd,sc9836-uart" + * "sprd,sc9860-uart", "sprd,sc9836-uart" + - reg: offset and length of the register set for the device - interrupts: exactly one interrupt specifier - clocks: phandles to input clocks. + +Example: + uart0: serial@000000 { + compatible = "sprd,sc9860-uart", + "sprd,sc9836-uart"; + reg = <0x000000 0x100>; + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + };
SC9860 use the same serial device which SC9836 uses, so added a new compatible string to support SC9860 as well, also added an example of how to describe this serial device in DT. Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> --- Documentation/devicetree/bindings/serial/sprd-uart.txt | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)