| Message ID | 1287064547-8876-1-git-send-email-galak@kernel.crashing.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Kumar Gala |
| Headers | show |
On Thu, Oct 14, 2010 at 08:55:47AM -0500, Kumar Gala wrote: > We get the following when building on ppc64 due to lack of include of > <asm/io.h>: Is this an immediate problem (merge for .36), or is it a linux-next thing? g. > > In file included from drivers/spi/spi_fsl_espi.c:25:0: > drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_write_reg': > drivers/spi/spi_fsl_lib.h:88:2: error: implicit declaration of function 'out_be32' > drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_read_reg': > drivers/spi/spi_fsl_lib.h:93:2: error: implicit declaration of function 'in_be32' > drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_remove': > drivers/spi/spi_fsl_espi.c:571:2: error: implicit declaration of function 'iounmap' > drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_probe': > drivers/spi/spi_fsl_espi.c:602:2: error: implicit declaration of function 'ioremap' > drivers/spi/spi_fsl_espi.c:602:24: warning: assignment makes pointer from integer without a cast > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > --- > drivers/spi/spi_fsl_lib.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/spi_fsl_lib.h b/drivers/spi/spi_fsl_lib.h > index 15aa6c2..281e060 100644 > --- a/drivers/spi/spi_fsl_lib.h > +++ b/drivers/spi/spi_fsl_lib.h > @@ -18,6 +18,8 @@ > #ifndef __SPI_FSL_LIB_H__ > #define __SPI_FSL_LIB_H__ > > +#include <asm/io.h> > + > /* SPI/eSPI Controller driver's private data. */ > struct mpc8xxx_spi { > struct device *dev; > -- > 1.7.2.3 >
On Oct 14, 2010, at 9:12 AM, Grant Likely wrote: > On Thu, Oct 14, 2010 at 08:55:47AM -0500, Kumar Gala wrote: >> We get the following when building on ppc64 due to lack of include of >> <asm/io.h>: > > Is this an immediate problem (merge for .36), or is it a linux-next thing? > > g. .37 / next is fine. - k
On Thu, Oct 14, 2010 at 08:55:47AM -0500, Kumar Gala wrote: > We get the following when building on ppc64 due to lack of include of > <asm/io.h>: Applied. g. > > In file included from drivers/spi/spi_fsl_espi.c:25:0: > drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_write_reg': > drivers/spi/spi_fsl_lib.h:88:2: error: implicit declaration of function 'out_be32' > drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_read_reg': > drivers/spi/spi_fsl_lib.h:93:2: error: implicit declaration of function 'in_be32' > drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_remove': > drivers/spi/spi_fsl_espi.c:571:2: error: implicit declaration of function 'iounmap' > drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_probe': > drivers/spi/spi_fsl_espi.c:602:2: error: implicit declaration of function 'ioremap' > drivers/spi/spi_fsl_espi.c:602:24: warning: assignment makes pointer from integer without a cast > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > --- > drivers/spi/spi_fsl_lib.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/spi_fsl_lib.h b/drivers/spi/spi_fsl_lib.h > index 15aa6c2..281e060 100644 > --- a/drivers/spi/spi_fsl_lib.h > +++ b/drivers/spi/spi_fsl_lib.h > @@ -18,6 +18,8 @@ > #ifndef __SPI_FSL_LIB_H__ > #define __SPI_FSL_LIB_H__ > > +#include <asm/io.h> > + > /* SPI/eSPI Controller driver's private data. */ > struct mpc8xxx_spi { > struct device *dev; > -- > 1.7.2.3 >
diff --git a/drivers/spi/spi_fsl_lib.h b/drivers/spi/spi_fsl_lib.h index 15aa6c2..281e060 100644 --- a/drivers/spi/spi_fsl_lib.h +++ b/drivers/spi/spi_fsl_lib.h @@ -18,6 +18,8 @@ #ifndef __SPI_FSL_LIB_H__ #define __SPI_FSL_LIB_H__ +#include <asm/io.h> + /* SPI/eSPI Controller driver's private data. */ struct mpc8xxx_spi { struct device *dev;
We get the following when building on ppc64 due to lack of include of <asm/io.h>: In file included from drivers/spi/spi_fsl_espi.c:25:0: drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_write_reg': drivers/spi/spi_fsl_lib.h:88:2: error: implicit declaration of function 'out_be32' drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_read_reg': drivers/spi/spi_fsl_lib.h:93:2: error: implicit declaration of function 'in_be32' drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_remove': drivers/spi/spi_fsl_espi.c:571:2: error: implicit declaration of function 'iounmap' drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_probe': drivers/spi/spi_fsl_espi.c:602:2: error: implicit declaration of function 'ioremap' drivers/spi/spi_fsl_espi.c:602:24: warning: assignment makes pointer from integer without a cast Signed-off-by: Kumar Gala <galak@kernel.crashing.org> --- drivers/spi/spi_fsl_lib.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)