diff mbox

[net] sctp: define dst_pending_confirm as a bit in sctp_transport

Message ID b4390881b14adce583817529e5d58599acb5a8ee.1489836443.git.lucien.xin@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Xin Long March 18, 2017, 11:27 a.m. UTC
As tp->dst_pending_confirm's value can only be set 0 or 1, this
patch is to change to define it as a bit instead of __u32.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
 include/net/sctp/structs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Neil Horman March 18, 2017, 7:07 p.m. UTC | #1
On Sat, Mar 18, 2017 at 07:27:23PM +0800, Xin Long wrote:
> As tp->dst_pending_confirm's value can only be set 0 or 1, this
> patch is to change to define it as a bit instead of __u32.
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
>  include/net/sctp/structs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 07a0b12..4f64519 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -753,6 +753,8 @@ struct sctp_transport {
>  		/* Is the Path MTU update pending on this tranport */
>  		pmtu_pending:1,
>  
> +		dst_pending_confirm:1,	/* need to confirm neighbour */
> +
>  		/* Has this transport moved the ctsn since we last sacked */
>  		sack_generation:1;
>  	u32 dst_cookie;
> @@ -806,8 +808,6 @@ struct sctp_transport {
>  
>  	__u32 burst_limited;	/* Holds old cwnd when max.burst is applied */
>  
> -	__u32 dst_pending_confirm;	/* need to confirm neighbour */
> -
>  	/* Destination */
>  	struct dst_entry *dst;
>  	/* Source address. */
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>
David Miller March 22, 2017, 1:32 a.m. UTC | #2
From: Xin Long <lucien.xin@gmail.com>
Date: Sat, 18 Mar 2017 19:27:23 +0800

> As tp->dst_pending_confirm's value can only be set 0 or 1, this
> patch is to change to define it as a bit instead of __u32.
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>

Applied.
diff mbox

Patch

diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
index 07a0b12..4f64519 100644
--- a/include/net/sctp/structs.h
+++ b/include/net/sctp/structs.h
@@ -753,6 +753,8 @@  struct sctp_transport {
 		/* Is the Path MTU update pending on this tranport */
 		pmtu_pending:1,
 
+		dst_pending_confirm:1,	/* need to confirm neighbour */
+
 		/* Has this transport moved the ctsn since we last sacked */
 		sack_generation:1;
 	u32 dst_cookie;
@@ -806,8 +808,6 @@  struct sctp_transport {
 
 	__u32 burst_limited;	/* Holds old cwnd when max.burst is applied */
 
-	__u32 dst_pending_confirm;	/* need to confirm neighbour */
-
 	/* Destination */
 	struct dst_entry *dst;
 	/* Source address. */