| Message ID | 1490060356096-474442.post@n7.nabble.com |
|---|---|
| State | New |
| Headers | show |
On 03/20/2017 08:39 PM, wangguang wrote: > Subject: [PATCH]COLO:Fix spell error in Colo doc I added qemu-trivial in v4; you should keep it in the loop. Still missing a space after ':' in the subject line, and still the awkward duplication of the subject line in the body of the commit message. > > This is an error in COLO-FT.txt. > secondeary-disk0 should be secondary-disk0. > > Signed-off-by: Guang Wang <wang.guang55@zte.com.cn> Since I gave R-b on v4, it's worth adding it here to save time to show that no code has changed since that submission. Otherwise, it's nice to mention (after the --- separator) what changed from the previous version to cause you to send the next revision. At any rate, Reviewed-by: Eric Blake <eblake@redhat.com> > --- > docs/COLO-FT.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt > index e289be2..bec7547 100644 > --- a/docs/COLO-FT.txt > +++ b/docs/COLO-FT.txt > @@ -139,7 +139,7 @@ Secondary: > { 'execute': 'nbd-server-start', > 'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx', > 'port': '8889'} } } > } > -{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0', > 'writable': true } } > +{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0', > 'writable': true } } > > Note: > a. The qmp command nbd-server-start and nbd-server-add must be run >
21.03.2017 04:53, Eric Blake wrote: > On 03/20/2017 08:39 PM, wangguang wrote: >> Subject: [PATCH]COLO:Fix spell error in Colo doc > > I added qemu-trivial in v4; you should keep it in the loop. > > Still missing a space after ':' in the subject line, and still the > awkward duplication of the subject line in the body of the commit message. ... As Zhang Chen pointed out in the original patch submission, this patch isn't really needed since the command is actually different, and he'll update the doc later. Thanks, /mjt
diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index e289be2..bec7547 100644 --- a/docs/COLO-FT.txt +++ b/docs/COLO-FT.txt @@ -139,7 +139,7 @@ Secondary: { 'execute': 'nbd-server-start', 'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx', 'port': '8889'} } } } -{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0', 'writable': true } } +{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0', 'writable': true } }
Subject: [PATCH]COLO:Fix spell error in Colo doc This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang <wang.guang55@zte.com.cn> --- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Note: a. The qmp command nbd-server-start and nbd-server-add must be run