| Message ID | 1490056074976-474433.post@n7.nabble.com |
|---|---|
| State | New |
| Headers | show |
[adding qemu-trivial] On 03/20/2017 07:27 PM, wangguang wrote: > Subject: [PATCH] Fix Colo doc secondeary should be secondary This line feels redundant compared to the overall mail's subject line. In turn, that subject could use a space after colon. > This is an error in COLO-FT.txt. > secondeary-disk0 should be secondary-disk0. > > Signed-off-by: Guang Wang <wang.guang55@zte.com.cn> > --- > docs/COLO-FT.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> As it is doc-only, it is safe for hard freeze, but also not the end of the world if it doesn't go in until 2.10. > > diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt > index e289be2..bec7547 100644 > --- a/docs/COLO-FT.txt > +++ b/docs/COLO-FT.txt > @@ -139,7 +139,7 @@ Secondary: > { 'execute': 'nbd-server-start', > 'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx', > 'port': '8889'} } } > } > -{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0', > 'writable': true } } > +{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0', > 'writable': true } } > > Note: > a. The qmp command nbd-server-start and nbd-server-add must be run >
* Eric Blake (eblake@redhat.com) wrote: > [adding qemu-trivial] > > On 03/20/2017 07:27 PM, wangguang wrote: > > Subject: [PATCH] Fix Colo doc secondeary should be secondary > > This line feels redundant compared to the overall mail's subject line. > In turn, that subject could use a space after colon. > > > This is an error in COLO-FT.txt. > > secondeary-disk0 should be secondary-disk0. > > > > Signed-off-by: Guang Wang <wang.guang55@zte.com.cn> > > --- > > docs/COLO-FT.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Eric Blake <eblake@redhat.com> > > As it is doc-only, it is safe for hard freeze, but also not the end of > the world if it doesn't go in until 2.10. Manually applied and queued for migration (ahem a little late) Dave > > > > diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt > > index e289be2..bec7547 100644 > > --- a/docs/COLO-FT.txt > > +++ b/docs/COLO-FT.txt > > @@ -139,7 +139,7 @@ Secondary: > > { 'execute': 'nbd-server-start', > > 'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx', > > 'port': '8889'} } } > > } > > -{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0', > > 'writable': true } } > > +{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0', > > 'writable': true } } > > > > Note: > > a. The qmp command nbd-server-start and nbd-server-add must be run > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index e289be2..bec7547 100644 --- a/docs/COLO-FT.txt +++ b/docs/COLO-FT.txt @@ -139,7 +139,7 @@ Secondary: { 'execute': 'nbd-server-start', 'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx', 'port': '8889'} } } } -{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0', 'writable': true } } +{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0', 'writable': true } }
Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang <wang.guang55@zte.com.cn> --- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Note: a. The qmp command nbd-server-start and nbd-server-add must be run