| Message ID | 20170320133730.23041-1-oneukum@suse.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi, On 20-03-17 14:37, Oliver Neukum wrote: > Our testing shows the semaphore failing to be transferred on CherryTrail > in about 0.5% of all cases. The existing timeout needs to be lengthened > to accomodate the worst cases. > > V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail > > Signed-off-by: Oliver Neukum <oneukum@suse.com> Looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/i2c/busses/i2c-designware-baytrail.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-designware-baytrail.c b/drivers/i2c/busses/i2c-designware-baytrail.c > index 1749a0f..c0e7c88 100644 > --- a/drivers/i2c/busses/i2c-designware-baytrail.c > +++ b/drivers/i2c/busses/i2c-designware-baytrail.c > @@ -22,7 +22,7 @@ > > #include "i2c-designware-core.h" > > -#define SEMAPHORE_TIMEOUT 100 > +#define SEMAPHORE_TIMEOUT 500 > #define PUNIT_SEMAPHORE 0x7 > #define PUNIT_SEMAPHORE_CHT 0x10e > #define PUNIT_SEMAPHORE_BIT BIT(0) > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/20/17 15:39, Hans de Goede wrote: > Hi, > > On 20-03-17 14:37, Oliver Neukum wrote: >> Our testing shows the semaphore failing to be transferred on CherryTrail >> in about 0.5% of all cases. The existing timeout needs to be lengthened >> to accomodate the worst cases. >> >> V2: Rebased on >> https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail >> >> >> Signed-off-by: Oliver Neukum <oneukum@suse.com> > > Looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 20, 2017 at 02:37:30PM +0100, Oliver Neukum wrote: > Our testing shows the semaphore failing to be transferred on CherryTrail > in about 0.5% of all cases. The existing timeout needs to be lengthened > to accomodate the worst cases. > > V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail > > Signed-off-by: Oliver Neukum <oneukum@suse.com> Fixed this checkpatch issue: WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'? and applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-designware-baytrail.c b/drivers/i2c/busses/i2c-designware-baytrail.c index 1749a0f..c0e7c88 100644 --- a/drivers/i2c/busses/i2c-designware-baytrail.c +++ b/drivers/i2c/busses/i2c-designware-baytrail.c @@ -22,7 +22,7 @@ #include "i2c-designware-core.h" -#define SEMAPHORE_TIMEOUT 100 +#define SEMAPHORE_TIMEOUT 500 #define PUNIT_SEMAPHORE 0x7 #define PUNIT_SEMAPHORE_CHT 0x10e #define PUNIT_SEMAPHORE_BIT BIT(0)
Our testing shows the semaphore failing to be transferred on CherryTrail in about 0.5% of all cases. The existing timeout needs to be lengthened to accomodate the worst cases. V2: Rebased on https://cgit.freedesktop.org/drm-intel/commit/?h=topic/designware-baytrail Signed-off-by: Oliver Neukum <oneukum@suse.com> --- drivers/i2c/busses/i2c-designware-baytrail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)