| Message ID | 1286910141.16797.23.camel@lb-tlvb-dmitry |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Le mardi 12 octobre 2010 à 21:02 +0200, Dmitry Kravkov a écrit : > Reported-by: Eric Dumazet <eric.dumazet@gmail.com> > > Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com> > Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com> > --- > drivers/net/bnx2x/bnx2x_main.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c > index 7a9556b..ead524b 100644 > --- a/drivers/net/bnx2x/bnx2x_main.c > +++ b/drivers/net/bnx2x/bnx2x_main.c > @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp) > * if (is_eth_multi(bp)) > * flags |= FUNC_FLG_RSS; > */ > + flags |= FUNC_FLG_RSS; > > /* function setup */ > if (flags & FUNC_FLG_RSS) { Thanks, this solved the problem. Tested-by: Eric Dumazet <eric.dumazet@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2010-10-12 at 21:02 +0200, Dmitry Kravkov wrote: > Reported-by: Eric Dumazet <eric.dumazet@gmail.com> > > Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com> > Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com> > --- > drivers/net/bnx2x/bnx2x_main.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c > index 7a9556b..ead524b 100644 > --- a/drivers/net/bnx2x/bnx2x_main.c > +++ b/drivers/net/bnx2x/bnx2x_main.c > @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp) > * if (is_eth_multi(bp)) > * flags |= FUNC_FLG_RSS; > */ > + flags |= FUNC_FLG_RSS; > > /* function setup */ > if (flags & FUNC_FLG_RSS) { Then the "if (flags & FUNC_FLG_RSS)" test should be removed. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Tue, 12 Oct 2010 21:18:49 +0200 > Le mardi 12 octobre 2010 à 21:02 +0200, Dmitry Kravkov a écrit : >> Reported-by: Eric Dumazet <eric.dumazet@gmail.com> >> >> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com> >> Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com> ... > Thanks, this solved the problem. > > Tested-by: Eric Dumazet <eric.dumazet@gmail.com> Applied, thanks guys. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Joe Perches <joe@perches.com> Date: Tue, 12 Oct 2010 12:26:19 -0700 > On Tue, 2010-10-12 at 21:02 +0200, Dmitry Kravkov wrote: >> @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp) >> * if (is_eth_multi(bp)) >> * flags |= FUNC_FLG_RSS; >> */ >> + flags |= FUNC_FLG_RSS; >> >> /* function setup */ >> if (flags & FUNC_FLG_RSS) { > > Then the "if (flags & FUNC_FLG_RSS)" test should be removed. Yeah it probably should. If necessary it could be added back later. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Tuesday, October 12, 2010 9:32 PM > To: joe@perches.com > Cc: Dmitry Kravkov; netdev@vger.kernel.org; eric.dumazet@gmail.com; > Vladislav Zolotarov; Eilon Greenstein > Subject: Re: [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS > enablement > > From: Joe Perches <joe@perches.com> > Date: Tue, 12 Oct 2010 12:26:19 -0700 > > > On Tue, 2010-10-12 at 21:02 +0200, Dmitry Kravkov wrote: > >> @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp) > >> * if (is_eth_multi(bp)) > >> * flags |= FUNC_FLG_RSS; > >> */ > >> + flags |= FUNC_FLG_RSS; > >> > >> /* function setup */ > >> if (flags & FUNC_FLG_RSS) { > > > > Then the "if (flags & FUNC_FLG_RSS)" test should be removed. > > Yeah it probably should. If necessary it could be added back > later. Thanks, Joe. We will consider removing this "if" and will post an appropriate patch. Most likely in the close patch series we have promised to respin... ;) Thanks to all, guys. vlad -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c index 7a9556b..ead524b 100644 --- a/drivers/net/bnx2x/bnx2x_main.c +++ b/drivers/net/bnx2x/bnx2x_main.c @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp) * if (is_eth_multi(bp)) * flags |= FUNC_FLG_RSS; */ + flags |= FUNC_FLG_RSS; /* function setup */ if (flags & FUNC_FLG_RSS) {