| Message ID | 20170320095721.6724-1-borneo.antonio@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 20-03-17, 10:57, Antonio Borneo wrote: > The properties "pl022,hierarchy" and "pl022,slave-tx-disable" are > not documented in DT binding and don't exist in the driver code. > They have no effect and can be removed. > > Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> > --- > Cc: Mark Brown <broonie@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > To: Viresh Kumar <vireshk@kernel.org> > To: Shiraz Hashim <shiraz.linux.kernel@gmail.com> > Cc: Russell King <linux@armlinux.org.uk> > Cc: Brijesh Singh <brijeshkumar.singh@amd.com> > Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> > Cc: Tom Lendacky <thomas.lendacky@amd.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: Jon Mason <jonmason@broadcom.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-spi@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm/boot/dts/spear1310-evb.dts | 6 ------ > arch/arm/boot/dts/spear1340-evb.dts | 6 ------ > 2 files changed, 12 deletions(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Mon, Mar 20, 2017 at 10:57:18AM +0100, Antonio Borneo wrote: > The properties "pl022,hierarchy" and "pl022,slave-tx-disable" were > initially proposed till patch V4 [1] but then discarded in V5 [2] > when the patch set was taken over by another developer, as > explained in patch history in [3]. > The above properties never landed in mainline code but were then > listed in the binding example by a following commit dc715452e914 > ("spi: pl022: use generic DMA slave configuration if possible") > and later on they were copy-paste in some board's DT. > > Remove the nonexistent properties from the example. > Also remove a spaces-only line at the end of the file. > > [1] https://lkml.org/lkml/2012/7/9/421 > [2] https://lkml.org/lkml/2012/8/21/427 > [3] https://lkml.org/lkml/2012/8/21/436 > > Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> For the series: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt > index 4d1673ca8cf8..2692a5726c3f 100644 > --- a/Documentation/devicetree/bindings/spi/spi_pl022.txt > +++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt > @@ -56,9 +56,7 @@ Example: > spi-max-frequency = <12000000>; > spi-cpol; > spi-cpha; > - pl022,hierarchy = <0>; > pl022,interface = <0>; > - pl022,slave-tx-disable; > pl022,com-mode = <0x2>; > pl022,rx-level-trig = <0>; > pl022,tx-level-trig = <0>; > @@ -67,4 +65,3 @@ Example: > pl022,duplex = <0>; > }; > }; > - > -- > 2.12.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt index 4d1673ca8cf8..2692a5726c3f 100644 --- a/Documentation/devicetree/bindings/spi/spi_pl022.txt +++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt @@ -56,9 +56,7 @@ Example: spi-max-frequency = <12000000>; spi-cpol; spi-cpha; - pl022,hierarchy = <0>; pl022,interface = <0>; - pl022,slave-tx-disable; pl022,com-mode = <0x2>; pl022,rx-level-trig = <0>; pl022,tx-level-trig = <0>; @@ -67,4 +65,3 @@ Example: pl022,duplex = <0>; }; }; -
The properties "pl022,hierarchy" and "pl022,slave-tx-disable" were initially proposed till patch V4 [1] but then discarded in V5 [2] when the patch set was taken over by another developer, as explained in patch history in [3]. The above properties never landed in mainline code but were then listed in the binding example by a following commit dc715452e914 ("spi: pl022: use generic DMA slave configuration if possible") and later on they were copy-paste in some board's DT. Remove the nonexistent properties from the example. Also remove a spaces-only line at the end of the file. [1] https://lkml.org/lkml/2012/7/9/421 [2] https://lkml.org/lkml/2012/8/21/427 [3] https://lkml.org/lkml/2012/8/21/436 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> --- To: Mark Brown <broonie@kernel.org> To: Rob Herring <robh+dt@kernel.org> To: Mark Rutland <mark.rutland@arm.com> Cc: Viresh Kumar <vireshk@kernel.org> Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com> Cc: Russell King <linux@armlinux.org.uk> Cc: Brijesh Singh <brijeshkumar.singh@amd.com> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> Cc: Tom Lendacky <thomas.lendacky@amd.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: Jon Mason <jonmason@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-spi@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- Documentation/devicetree/bindings/spi/spi_pl022.txt | 3 --- 1 file changed, 3 deletions(-)