| Message ID | 1489654145-20532-3-git-send-email-ogerlitz@mellanox.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello! On 3/16/2017 11:49 AM, Or Gerlitz wrote: > The code introduced by commit 2ccccf5fb "net_sched: update hierarchical > backlog too" only sets prev_backlog in fq_codel_dequeue() but not Need 12 hex digits and () around "<summary>"; see Documentation/process/submitting-patches.rst. > using that anywhere, remove that setting. > > Cc: Cong Wang <xiyou.wangcong@gmail.com> > Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com> [...] MBR, Sergei
diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c index 9f3a884..097bbe9 100644 --- a/net/sched/sch_fq_codel.c +++ b/net/sched/sch_fq_codel.c @@ -288,7 +288,6 @@ static struct sk_buff *fq_codel_dequeue(struct Qdisc *sch) struct fq_codel_flow *flow; struct list_head *head; u32 prev_drop_count, prev_ecn_mark; - unsigned int prev_backlog; begin: head = &q->new_flows; @@ -307,7 +306,6 @@ static struct sk_buff *fq_codel_dequeue(struct Qdisc *sch) prev_drop_count = q->cstats.drop_count; prev_ecn_mark = q->cstats.ecn_mark; - prev_backlog = sch->qstats.backlog; skb = codel_dequeue(sch, &sch->qstats.backlog, &q->cparams, &flow->cvars, &q->cstats, qdisc_pkt_len,
The code introduced by commit 2ccccf5fb "net_sched: update hierarchical backlog too" only sets prev_backlog in fq_codel_dequeue() but not using that anywhere, remove that setting. Cc: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com> --- net/sched/sch_fq_codel.c | 2 -- 1 file changed, 2 deletions(-)