| Message ID | 1489433702-3044-1-git-send-email-mfornero@mathworks.com |
|---|---|
| State | Accepted |
| Headers | show |
Makes sense.
Acked-By: Paul Cercueil <paul.cercueil@analog.com>
Hello, On Mon, 13 Mar 2017 15:35:02 -0400, Matthew Fornero wrote: > If building on a machine with MATLAB installed, the MATLAB bindings will > default to ON, which is not the desired behavior for a cross build. > > The bindings are designed to be called from within MATLAB, and we are > not currently running MATLAB on buildroot-generated targets. > > This does not preclude the use of the bindings from a host connecting > over the network backend (assuming libiio on the host has the bindings > enabled). > > Signed-off-by: Matthew Fornero <mfornero@mathworks.com> > --- > package/libiio/libiio.mk | 1 + > 1 file changed, 1 insertion(+) Applied to master, after slightly tweaking the commit title. Thanks! Peter: perhaps we want this for the LTS branch? Not sure. Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > Hello, > On Mon, 13 Mar 2017 15:35:02 -0400, Matthew Fornero wrote: >> If building on a machine with MATLAB installed, the MATLAB bindings will >> default to ON, which is not the desired behavior for a cross build. >> >> The bindings are designed to be called from within MATLAB, and we are >> not currently running MATLAB on buildroot-generated targets. >> >> This does not preclude the use of the bindings from a host connecting >> over the network backend (assuming libiio on the host has the bindings >> enabled). >> >> Signed-off-by: Matthew Fornero <mfornero@mathworks.com> >> --- >> package/libiio/libiio.mk | 1 + >> 1 file changed, 1 insertion(+) > Applied to master, after slightly tweaking the commit title. Thanks! > Peter: perhaps we want this for the LTS branch? Not sure. It seems pretty safe to add it. Committed to 2017.02.x, thanks.
diff --git a/package/libiio/libiio.mk b/package/libiio/libiio.mk index 8977610..aaa6c70 100644 --- a/package/libiio/libiio.mk +++ b/package/libiio/libiio.mk @@ -14,6 +14,7 @@ LIBIIO_CONF_OPTS = -DENABLE_IPV6=ON \ -DWITH_LOCAL_BACKEND=$(if $(BR2_PACKAGE_LIBIIO_LOCAL_BACKEND),ON,OFF) \ -DWITH_NETWORK_BACKEND=$(if $(BR2_PACKAGE_LIBIIO_NETWORK_BACKEND),ON,OFF) \ -DWITH_MATLAB_BINDINGS_API=OFF \ + -DMATLAB_BINDINGS=OFF \ -DINSTALL_UDEV_RULE=$(if $(BR2_PACKAGE_HAS_UDEV),ON,OFF) \ -DWITH_TESTS=$(if $(BR2_PACKAGE_LIBIIO_TESTS),ON,OFF) \ -DWITH_DOC=OFF
If building on a machine with MATLAB installed, the MATLAB bindings will default to ON, which is not the desired behavior for a cross build. The bindings are designed to be called from within MATLAB, and we are not currently running MATLAB on buildroot-generated targets. This does not preclude the use of the bindings from a host connecting over the network backend (assuming libiio on the host has the bindings enabled). Signed-off-by: Matthew Fornero <mfornero@mathworks.com> --- package/libiio/libiio.mk | 1 + 1 file changed, 1 insertion(+)