| Message ID | 20081102172650.GA7219@x200.localdomain (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | fce4d58353e449a1ac637fc8d2b994e0fcc55312 |
| Delegated to: | Paul Mackerras |
| Headers | show |
On Sun, 2 Nov 2008, Alexey Dobriyan wrote: > drivers/ps3/ps3-lpm.c:838: error: implicit declaration of function 'get_hard_smp_processor_id' > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > --- > > drivers/ps3/ps3-lpm.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/ps3/ps3-lpm.c > +++ b/drivers/ps3/ps3-lpm.c > @@ -22,6 +22,7 @@ > #include <linux/module.h> > #include <linux/interrupt.h> > #include <linux/uaccess.h> > +#include <asm/smp.h> #include <linux/smp.h>? > #include <asm/time.h> > #include <asm/ps3.h> > #include <asm/lv1call.h> > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010
On Mon, Nov 03, 2008 at 09:20:28AM +0100, Geert Uytterhoeven wrote: > On Sun, 2 Nov 2008, Alexey Dobriyan wrote: > > drivers/ps3/ps3-lpm.c:838: error: implicit declaration of function 'get_hard_smp_processor_id' > > > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > > --- > > > > drivers/ps3/ps3-lpm.c | 1 + > > 1 file changed, 1 insertion(+) > > > > --- a/drivers/ps3/ps3-lpm.c > > +++ b/drivers/ps3/ps3-lpm.c > > @@ -22,6 +22,7 @@ > > #include <linux/module.h> > > #include <linux/interrupt.h> > > #include <linux/uaccess.h> > > +#include <asm/smp.h> > > #include <linux/smp.h>? Nope, everybody else uses asm/smp.h.
Alexey Dobriyan wrote: > On Mon, Nov 03, 2008 at 09:20:28AM +0100, Geert Uytterhoeven wrote: >> On Sun, 2 Nov 2008, Alexey Dobriyan wrote: >> > drivers/ps3/ps3-lpm.c:838: error: implicit declaration of function 'get_hard_smp_processor_id' >> > >> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Acked-by: Geoff Levand <geoffrey.levand@am.sony.com> >> > --- a/drivers/ps3/ps3-lpm.c >> > +++ b/drivers/ps3/ps3-lpm.c >> > @@ -22,6 +22,7 @@ >> > #include <linux/module.h> >> > #include <linux/interrupt.h> >> > #include <linux/uaccess.h> >> > +#include <asm/smp.h> >> >> #include <linux/smp.h>? > > Nope, everybody else uses asm/smp.h. That doesn't quite seem like enough reason for me. Looking at the source, I see linux/smp.h only includes asm/smp.h when CONFIG_SMP=y, so we at least need to include asm/smp.h to get the get_hard_smp_processor_id def when CONFIG_SMP=n. -Geoff
--- a/drivers/ps3/ps3-lpm.c +++ b/drivers/ps3/ps3-lpm.c @@ -22,6 +22,7 @@ #include <linux/module.h> #include <linux/interrupt.h> #include <linux/uaccess.h> +#include <asm/smp.h> #include <asm/time.h> #include <asm/ps3.h> #include <asm/lv1call.h>
drivers/ps3/ps3-lpm.c:838: error: implicit declaration of function 'get_hard_smp_processor_id' Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- drivers/ps3/ps3-lpm.c | 1 + 1 file changed, 1 insertion(+)