| Message ID | 5077e2a9732e1b9afcb0754e93624b787589ac61.1487522123.git.balaton@eik.bme.hu |
|---|---|
| State | New |
| Headers | show |
On 19 February 2017 at 16:35, BALATON Zoltan <balaton@eik.bme.hu> wrote: > This is not used by default on any emulated machine yet but it is > still useful to have it compiled so it can be added from the command > line for clients that can use it (e.g. MorphOS has no driver for any > other emulated video cards but can output via SM501) > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> If this is a generic PCI device then shouldn't it go into default-configs/pci.mak ? thanks -- PMM
On Fri, 24 Feb 2017, Peter Maydell wrote: > On 19 February 2017 at 16:35, BALATON Zoltan <balaton@eik.bme.hu> wrote: >> This is not used by default on any emulated machine yet but it is >> still useful to have it compiled so it can be added from the command >> line for clients that can use it (e.g. MorphOS has no driver for any >> other emulated video cards but can output via SM501) >> >> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> > > If this is a generic PCI device then shouldn't it go into > default-configs/pci.mak ? This is a multimedia chip usually found on sh4 systems and some ppc boards that's why I've only added it to these but I can move it to pci.mak if you think it's a better place for it. Thanks again for taking the time to review, if you could answer these questions I can try to prepare a v2.
On 24.02.2017 21:51, BALATON Zoltan wrote: > On Fri, 24 Feb 2017, Peter Maydell wrote: >> On 19 February 2017 at 16:35, BALATON Zoltan <balaton@eik.bme.hu> wrote: >>> This is not used by default on any emulated machine yet but it is >>> still useful to have it compiled so it can be added from the command >>> line for clients that can use it (e.g. MorphOS has no driver for any >>> other emulated video cards but can output via SM501) >>> >>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> >> >> If this is a generic PCI device then shouldn't it go into >> default-configs/pci.mak ? > > This is a multimedia chip usually found on sh4 systems and some ppc > boards that's why I've only added it to these but I can move it to > pci.mak if you think it's a better place for it. If it is not really usable for other boards, then I think it should also not go into pci.mak. No need to confuse the users of the other boards with unusable PCI cards here. Thomas
diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak index 09c1d45..1f1cd85 100644 --- a/default-configs/ppc-softmmu.mak +++ b/default-configs/ppc-softmmu.mak @@ -45,6 +45,7 @@ CONFIG_OPENPIC_KVM=$(and $(CONFIG_E500),$(CONFIG_KVM)) CONFIG_PLATFORM_BUS=y CONFIG_ETSEC=y CONFIG_LIBDECNUMBER=y +CONFIG_SM501=y # For PReP CONFIG_SERIAL_ISA=y CONFIG_MC146818RTC=y diff --git a/default-configs/ppcemb-softmmu.mak b/default-configs/ppcemb-softmmu.mak index 7f56004..94340de 100644 --- a/default-configs/ppcemb-softmmu.mak +++ b/default-configs/ppcemb-softmmu.mak @@ -15,3 +15,4 @@ CONFIG_I8259=y CONFIG_XILINX=y CONFIG_XILINX_ETHLITE=y CONFIG_LIBDECNUMBER=y +CONFIG_SM501=y
This is not used by default on any emulated machine yet but it is still useful to have it compiled so it can be added from the command line for clients that can use it (e.g. MorphOS has no driver for any other emulated video cards but can output via SM501) Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- default-configs/ppc-softmmu.mak | 1 + default-configs/ppcemb-softmmu.mak | 1 + 2 files changed, 2 insertions(+)