| Message ID | b01bb0ae-361c-a28a-d372-f9a3881c0a9b@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On 2/02/2017 05:05, Heiner Kallweit wrote: > I can only imagine that this message ended up there by a copy & paste > mistake. The same message appears correctly a few lines later, but > here it doesn't make sense. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 460f94f5..5edf23dc 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -371,7 +371,6 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) > } else { > clk_prepare_enable(plat->clk_ptp_ref); > plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref); > - dev_info(&pdev->dev, "No reset control found\n"); > } > > plat->stmmac_rst = devm_reset_control_get(&pdev->dev, > It was originally: netdev_dbg(priv->dev, "PTP rate %d\n", priv->clk_ptp_rate); Before it got moved in: commit f573c0b9c4e02691cf87736bd0824fd37ec02e65 stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure
Am 02.02.2017 um 03:20 schrieb Phil Reid: > On 2/02/2017 05:05, Heiner Kallweit wrote: >> I can only imagine that this message ended up there by a copy & paste >> mistake. The same message appears correctly a few lines later, but >> here it doesn't make sense. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> --- >> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> index 460f94f5..5edf23dc 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> @@ -371,7 +371,6 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) >> } else { >> clk_prepare_enable(plat->clk_ptp_ref); >> plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref); >> - dev_info(&pdev->dev, "No reset control found\n"); >> } >> >> plat->stmmac_rst = devm_reset_control_get(&pdev->dev, >> > > It was originally: > netdev_dbg(priv->dev, "PTP rate %d\n", priv->clk_ptp_rate); > Before it got moved in: > commit f573c0b9c4e02691cf87736bd0824fd37ec02e65 > stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure > Thanks for the hint, I'll send a v2 to restore the original message.
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 460f94f5..5edf23dc 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -371,7 +371,6 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) } else { clk_prepare_enable(plat->clk_ptp_ref); plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref); - dev_info(&pdev->dev, "No reset control found\n"); } plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
I can only imagine that this message ended up there by a copy & paste mistake. The same message appears correctly a few lines later, but here it doesn't make sense. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 - 1 file changed, 1 deletion(-)