| Message ID | 1484600277-32345-4-git-send-email-vgupta@synopsys.com |
|---|---|
| State | New |
| Headers | show |
Hi Vineet, > -----Original Message----- > From: Vineet Gupta > Sent: Monday, January 16, 2017 11:58 PM > To: linux-snps-arc@lists.infradead.org; Alexey Brodkin > <abrodkin@synopsys.com> > Cc: linux-kernel@vger.kernel.org; Vineet Gupta <vgupta@synopsys.com> > Subject: [PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all cores > when one halts > > This was really usefull when doing initial bringup and also for occassional > debug of software and hardware bugs. However in the new smp-boot > regime, non masters will "self" halt even for run-on-reset configs. This will > misinteract with the debug feature as in even master will get halted when > the non masters self halt. > > Signed-off-by: Vineet Gupta <vgupta@synopsys.com> > --- > arch/arc/kernel/mcip.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arc/kernel/mcip.c b/arch/arc/kernel/mcip.c index > f39142acc89e..933382e0edd0 100644 > --- a/arch/arc/kernel/mcip.c > +++ b/arch/arc/kernel/mcip.c > @@ -101,11 +101,6 @@ static void mcip_probe_n_setup(void) > IS_AVAIL1(mp.gfrc, "GFRC")); > > cpuinfo_arc700[0].extn.gfrc = mp.gfrc; > - > - if (mp.dbg) { > - __mcip_cmd_data(CMD_DEBUG_SET_SELECT, 0, 0xf); > - __mcip_cmd_data(CMD_DEBUG_SET_MASK, 0xf, 0xf); > - } > } I've been doing that for quite some time locally because that used to be a must for execution of SMP vmlinux in "pseudo"-UP mode, i.e. on SMP hardware but with only 1 core being used. I'm really happy to see this commit upstream - will definitely make life a bit simpler. -Alexey
diff --git a/arch/arc/kernel/mcip.c b/arch/arc/kernel/mcip.c index f39142acc89e..933382e0edd0 100644 --- a/arch/arc/kernel/mcip.c +++ b/arch/arc/kernel/mcip.c @@ -101,11 +101,6 @@ static void mcip_probe_n_setup(void) IS_AVAIL1(mp.gfrc, "GFRC")); cpuinfo_arc700[0].extn.gfrc = mp.gfrc; - - if (mp.dbg) { - __mcip_cmd_data(CMD_DEBUG_SET_SELECT, 0, 0xf); - __mcip_cmd_data(CMD_DEBUG_SET_MASK, 0xf, 0xf); - } } struct plat_smp_ops plat_smp_ops = {
This was really usefull when doing initial bringup and also for occassional debug of software and hardware bugs. However in the new smp-boot regime, non masters will "self" halt even for run-on-reset configs. This will misinteract with the debug feature as in even master will get halted when the non masters self halt. Signed-off-by: Vineet Gupta <vgupta@synopsys.com> --- arch/arc/kernel/mcip.c | 5 ----- 1 file changed, 5 deletions(-)