| Message ID | 20161224093800.GA24893@rahul (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 12/24/2016 01:38 AM, Rahul Krishnan wrote: > > This patch removes unnecessary return statement using spatch tool > > Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com> Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> > --- > drivers/pci/hotplug/rpadlpar_core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > index dc67f39..78ce2c7 100644 > --- a/drivers/pci/hotplug/rpadlpar_core.c > +++ b/drivers/pci/hotplug/rpadlpar_core.c > @@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void) > > int __init rpadlpar_io_init(void) > { > - int rc = 0; > > if (!is_dlpar_capable()) { > printk(KERN_WARNING "%s: partition not DLPAR capable\n", > @@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void) > return -EPERM; > } > > - rc = dlpar_sysfs_init(); > - return rc; > + return dlpar_sysfs_init(); > } > > void rpadlpar_io_exit(void) >
On Sat, Dec 24, 2016 at 03:08:00PM +0530, Rahul Krishnan wrote: > > This patch removes unnecessary return statement using spatch tool > > Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com> Applied to pci/hotplug for v4.11 with Tyrel's Reviewed-by, thanks! Are there other similar instances elsewhere in drivers/pci? If so, can you fix them all at once? > --- > drivers/pci/hotplug/rpadlpar_core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > index dc67f39..78ce2c7 100644 > --- a/drivers/pci/hotplug/rpadlpar_core.c > +++ b/drivers/pci/hotplug/rpadlpar_core.c > @@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void) > > int __init rpadlpar_io_init(void) > { > - int rc = 0; > > if (!is_dlpar_capable()) { > printk(KERN_WARNING "%s: partition not DLPAR capable\n", > @@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void) > return -EPERM; > } > > - rc = dlpar_sysfs_init(); > - return rc; > + return dlpar_sysfs_init(); > } > > void rpadlpar_io_exit(void) > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 12, 2017 at 2:25 AM, Bjorn Helgaas <helgaas@kernel.org> wrote: > On Sat, Dec 24, 2016 at 03:08:00PM +0530, Rahul Krishnan wrote: > > > > This patch removes unnecessary return statement using spatch tool > > > > Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com> > > Applied to pci/hotplug for v4.11 with Tyrel's Reviewed-by, thanks! > > Are there other similar instances elsewhere in drivers/pci? If so, > can you fix them all at once? > Yes, I will look into it immediately. Thank you > > > --- > > drivers/pci/hotplug/rpadlpar_core.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/ > rpadlpar_core.c > > index dc67f39..78ce2c7 100644 > > --- a/drivers/pci/hotplug/rpadlpar_core.c > > +++ b/drivers/pci/hotplug/rpadlpar_core.c > > @@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void) > > > > int __init rpadlpar_io_init(void) > > { > > - int rc = 0; > > > > if (!is_dlpar_capable()) { > > printk(KERN_WARNING "%s: partition not DLPAR capable\n", > > @@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void) > > return -EPERM; > > } > > > > - rc = dlpar_sysfs_init(); > > - return rc; > > + return dlpar_sysfs_init(); > > } > > > > void rpadlpar_io_exit(void) > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html >
diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c index dc67f39..78ce2c7 100644 --- a/drivers/pci/hotplug/rpadlpar_core.c +++ b/drivers/pci/hotplug/rpadlpar_core.c @@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void) int __init rpadlpar_io_init(void) { - int rc = 0; if (!is_dlpar_capable()) { printk(KERN_WARNING "%s: partition not DLPAR capable\n", @@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void) return -EPERM; } - rc = dlpar_sysfs_init(); - return rc; + return dlpar_sysfs_init(); } void rpadlpar_io_exit(void)
This patch removes unnecessary return statement using spatch tool Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com> --- drivers/pci/hotplug/rpadlpar_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)