| Message ID | m2iq2cfs2u.fsf@igel.home (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
At Sat, 11 Sep 2010 13:16:41 +0200, Andreas Schwab wrote: > > Modifying an object twice without an intervening sequence point is > undefined. > > Signed-off-by: Andreas Schwab <schwab@linux-m68k.org> Applied now. Thanks. Takashi > --- > sound/ppc/tumbler.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/ppc/tumbler.c b/sound/ppc/tumbler.c > index 20afdf9..961d982 100644 > --- a/sound/ppc/tumbler.c > +++ b/sound/ppc/tumbler.c > @@ -785,7 +785,7 @@ static int snapper_set_capture_source(struct pmac_tumbler *mix) > if (! mix->i2c.client) > return -ENODEV; > if (mix->capture_source) > - mix->acs = mix->acs |= 2; > + mix->acs |= 2; > else > mix->acs &= ~2; > return i2c_smbus_write_byte_data(mix->i2c.client, TAS_REG_ACS, mix->acs); > -- > 1.7.2.3 > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different." > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
diff --git a/sound/ppc/tumbler.c b/sound/ppc/tumbler.c index 20afdf9..961d982 100644 --- a/sound/ppc/tumbler.c +++ b/sound/ppc/tumbler.c @@ -785,7 +785,7 @@ static int snapper_set_capture_source(struct pmac_tumbler *mix) if (! mix->i2c.client) return -ENODEV; if (mix->capture_source) - mix->acs = mix->acs |= 2; + mix->acs |= 2; else mix->acs &= ~2; return i2c_smbus_write_byte_data(mix->i2c.client, TAS_REG_ACS, mix->acs);
Modifying an object twice without an intervening sequence point is undefined. Signed-off-by: Andreas Schwab <schwab@linux-m68k.org> --- sound/ppc/tumbler.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)